Fix runInterpretResultsFor using the wrong AnalysisConfig for Code Quality category fix#3103
Merged
Fix runInterpretResultsFor using the wrong AnalysisConfig for Code Quality category fix#3103
runInterpretResultsFor using the wrong AnalysisConfig for Code Quality category fix#3103Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the runInterpretResultsFor function where the wrong analysis configuration was being used to determine if Code Quality category fix should be applied. The fix ensures that the category correction logic properly checks the individual analysis type rather than the database analysis configuration.
- Corrects variable reference from
dbAnalysisConfigtoanalysisin category check - Ensures Code Quality category fix is applied when processing individual Code Quality analyses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/analyze.ts | Fixed incorrect variable reference in Code Quality category check |
| lib/analyze-action.js | Generated JavaScript file (no review needed per guidelines) |
henrymercer
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We accidentally kept
dbAnalysisConfighere when refactoring this into its own function, instead ofanalysis. This meant that the check never succeeded, unlesscode-qualitywas the only active analysis.Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist