Add workflow generator option for installing Java#3036
Merged
Conversation
prepare-test action
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Java installation capability to the workflow generator to address Gradle 9 compatibility issues with JDK 8. The new installJava option allows workflows to automatically install JDK 17, which is required for Gradle 9.
- Adds
installJavaconfiguration option to the sync.py script that mirrors the existinginstallGofunctionality - Enables Java 17 installation for two autobuild direct tracing workflows that were failing with Gradle 9
- Generates workflow inputs and setup-java action steps when
installJava: "true"is specified
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pr-checks/sync.py | Core implementation of the installJava option with Java 17 default and Temurin distribution |
| pr-checks/checks/autobuild-direct-tracing.yml | Enables Java installation for autobuild direct tracing workflow |
| pr-checks/checks/autobuild-direct-tracing-with-working-dir.yml | Enables Java installation for autobuild direct tracing with working directory workflow |
| .github/workflows/__autobuild-direct-tracing.yml | Generated workflow with Java installation steps and inputs |
| .github/workflows/__autobuild-direct-tracing-with-working-dir.yml | Generated workflow with Java installation steps and inputs |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
henrymercer
previously approved these changes
Aug 15, 2025
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
CCR is correct, otherwise LGTM!
henrymercer
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle 9 is now the default version of Gradle on the GHA runners. This seems to cause failures because JDK 8 is the default and Gradle 9 requires JDK 17.
This PR adds a new
installJavaoption to thesync.pyscript which behaves exactly the same asinstallGo, except forsetup-java.I have added
installJava: "true"to the two workflows we have seen fail.Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist