PR checks: support collections of workflows#3030
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for collections of workflows in the PR checks system. It allows grouping related workflow checks (like Go-related checks) into collections that can be executed together.
- Adds collection functionality to the PR checks sync script
- Introduces workflow inputs for parameterizing check execution
- Creates a consolidated "go" collection containing all Go-related checks
Reviewed Changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pr-checks/sync.py | Main implementation adding collection support and workflow input handling |
| pr-checks/checks/go-*.yml | Go check specifications updated with collection membership and inputs |
| .github/workflows/__go.yml | New generated collection workflow for running all Go checks together |
| .github/workflows/__*.yml | Generated workflow files updated with workflow_call and workflow_dispatch inputs |
henrymercer
previously approved these changes
Aug 13, 2025
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
Nice! I like this. There is a little bit of awkwardness in the "go-version" input not being used in any of the steps, but it's not blocking.
c3ee05b to
20c329c
Compare
Member
Author
|
I manually dispatched a run of |
henrymercer
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sort-of experimental idea that I had in the context of #3028 where we bump the Go version in the workflows to a release candidate for testing purposes, but such PRs don't have to be merged anymore because the existing constraint of
>= 1.22would include allow new version once it is fully released.This PR updates the
sync.pyscript to allow "collections" of PR checks that can be triggered manually, with specific inputs. So instead of creating a PR that bumps the Go version for testing purposes only, we could instead just dispatch the collection workflow with the desired Go version.Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist