Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements version 3.28.20 of the CodeQL Action, which adds functionality to disable combining SARIF files from a single upload for GHES 3.18 and later versions. The changes introduce a new feature flag system for controlling this behavior and update version-checking logic to handle pre-release versions correctly.
Key changes:
- Adds a new utility function
satisfiesGHESVersionfor improved GHES version comparison that handles pre-release versions - Introduces the
DisableCombineSarifFilesfeature flag and corresponding logic to block SARIF file combining when appropriate - Updates deprecation timeline from "June 4, 2025" to "July 2025" for removing SARIF combining support
Reviewed Changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/util.ts | Adds satisfiesGHESVersion utility function for enhanced GHES version comparison |
| src/upload-lib.ts | Implements SARIF combining restrictions with new feature flag and error handling |
| src/upload-lib.test.ts | Adds comprehensive tests for the new SARIF combining restrictions |
| src/feature-flags.ts | Defines the new DisableCombineSarifFiles feature flag configuration |
| package.json | Updates version from 3.28.18 to 3.28.20 |
| CHANGELOG.md | Documents the removal of SARIF combining support for GHES 3.18 |
Comments suppressed due to low confidence (1)
src/util.ts:1143
- The parameter name
ghesVersionin the function signature doesn't match the JSDoc description which refers togithubVersion. Consider renaming the parameter togithubVersionfor consistency.
export function satisfiesGHESVersion(
mbg
approved these changes
Jul 21, 2025
Member
mbg
left a comment
There was a problem hiding this comment.
This seems fine to me. You should be good to tag this and create a release based on that tag as planned.
Member
Author
|
This release has been published: https://github.com/github/codeql-action/releases/tag/v3.28.20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to review changes for the v3.28.20 backport release. It is based on v3.28.18 since that is the version that's currently scheduled to be released in GHES 3.18. v3.28.19 will not be included in GHES 3.18.
This includes changes from these PRs: