Skip to content

feat: Add feature to enable dynamic ec2 config via workflow labels #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
edersonbrilhante wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: Add feature to enable dynamic ec2 config via workflow labels #5003

edersonbrilhante wants to merge 24 commits into from

Conversation

@edersonbrilhante
Copy link
Contributor

@edersonbrilhante edersonbrilhante commented Jan 19, 2026 •
edited
Loading

Summary

This PR resumes and completes the work started in #4529.

It also allows to use any other dynamic labels with prefix ghr-. Giving support for unique labels per job or per group of jobs

It ensures that EC2-specific config can be defined via run-ons

How to test:

Use your regular labels, and add ghr-ec2-instance-type and ghr-ec2-image-id

run-ons:
  - <regular-labels>
  - ghr-ec2-instance-type:<different-instance-type>
  - ghr-ec2-image-id:<different-ami-id>

In this case:

  • The runner is resolved from <regular-labels>
  • The EC2 instance type and AMI ID are taken exactly from the provided labels

@edersonbrilhante edersonbrilhante marked this pull request as ready for review January 20, 2026 16:16
@edersonbrilhante edersonbrilhante requested review from a team as code owners January 20, 2026 16:16
@npalm
Copy link
Member

npalm commented Jan 30, 2026

@edersonbrilhante great to see this PR.

npalm and others added 20 commits January 30, 2026 21:26
@npalm @edersonbrilhante
feat: Add feature to enable dynamic instance types via workflow labels
9515571
@edersonbrilhante
docs: auto update terraform docs
7319666
@edersonbrilhante
feat: allow to use dynamic instance type in multiple events
2da7824
@edersonbrilhante
style: fix format
c5a6524
@edersonbrilhante
fix: add dynamic labels as runner labels
139bb41
@edersonbrilhante
test: add tests for dynamic labels
6c3360d
@edersonbrilhante
fix: wire enable_dynamic_ec2_config
1d52f11
@edersonbrilhante
fix: fix runner owner logic
f4016d8
@edersonbrilhante
chore: decrease log level for some logs
a3a4a77
@edersonbrilhante
style: fix format issues
bde41b2
@edersonbrilhante
feat: add support for all fields in FleetLaunchTemplateOverridesRequest
f8bcd72
@edersonbrilhante
style: fix formatting issues
292c3e3
@edersonbrilhante
fix: convert instanceTypes to constant
b3e3714
@edersonbrilhante
test: fix test cases
44df86d
@edersonbrilhante
fix: fix imports
ec10436
@edersonbrilhante
docs: update function docs for parseEc2OverrideConfig
14f5a20
@edersonbrilhante
feat: allow use any dynamic label with prefix ghr-
786400f
@edersonbrilhante
style: fix formatting
67097e9
@github-actions @edersonbrilhante
docs: auto update terraform docs
d21aad5
@edersonbrilhante
fix: fix wrong variable
f880410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edersonbrilhante @npalm