Convert all remaining type annotations into the modern format#5239
Merged
alexander-alderman-webb merged 2 commits intogetsentry:masterfrom Dec 16, 2025
Merged
Convert all remaining type annotations into the modern format#5239alexander-alderman-webb merged 2 commits intogetsentry:masterfrom
alexander-alderman-webb merged 2 commits intogetsentry:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5239 +/- ##
==========================================
- Coverage 84.25% 84.15% -0.11%
==========================================
Files 181 182 +1
Lines 18463 18615 +152
Branches 3288 3318 +30
==========================================
+ Hits 15556 15665 +109
- Misses 1894 1931 +37
- Partials 1013 1019 +6
|
Contributor
|
Thanks for the PR @zsol, it's nice to have one approach to typing in the repo! We don't actually type check |
alexander-alderman-webb
approved these changes
Dec 16, 2025
e275c9e
into
getsentry:master
164 of 166 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as #5206 but for the
scripts/andtests/folder (plus there was one additional place insentry_sdkthat snuck in).