-
-
Notifications
You must be signed in to change notification settings - Fork 200
feat: (POC) offline caching #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JoshuaMoelans
wants to merge
11
commits into
master
Choose a base branch
from
joshua/feat/offline_caching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- (POC) offline caching ([#1461](https://github.com/getsentry/sentry-native/pull/1461))If none of the above apply, you can opt out of this check by adding |
- for now, we just have an option to keep dmp files on crash (for Breakpad)
jpnurmi
pushed a commit
that referenced
this pull request
Jan 23, 2026
Before "revert separate caching folder implementation" #1461
jpnurmi
pushed a commit
that referenced
this pull request
Jan 23, 2026
Before "revert separate caching folder implementation" #1461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily Work In Progress/exploratory
Current Implementation
For now, we just add an option to write
.dmpfiles to disk for Breakpad, allowing easier local debugging (since we only store up to 20 dumps per issue on Sentry, and to be useful these need debug symbols uploaded which during development doesn't happen).Tried Approaches
'developer caching'
Although this seems versatile, this opens up more complexity (without adding that much value).
.rundirectories into.sentry-native/cacheupon restart (while processing old runs) instead of removing them. We periodically clean this folder based on size/age, similar to how Crashpad does thisbreakpadwould write a minidump (which otherwise gets merged into the envelope), we keep this on disk too.cache_max_ageandcache_max_sizefor controlling the periodic cleanup.TODO
-> currently seems like one could look into
.sentry-native(or other configured database_path) and look at thecompletedfolder to see previous crash dump files.