Skip to content

Conversation

@MathurAditya724
Copy link
Member

@MathurAditya724 MathurAditya724 commented Jan 21, 2026

Closes #19076 (added automatically)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,958 - 11,325 -21%
GET With Sentry 1,757 20% 1,922 -9%
GET With Sentry (error only) 6,175 69% 7,578 -19%
POST Baseline 1,209 - 1,162 +4%
POST With Sentry 603 50% 584 +3%
POST With Sentry (error only) 1,056 87% 1,032 +2%
MYSQL Baseline 3,334 - 4,045 -18%
MYSQL With Sentry 514 15% 603 -15%
MYSQL With Sentry (error only) 2,720 82% 3,311 -18%

View base workflow run

@MathurAditya724 MathurAditya724 marked this pull request as ready for review January 29, 2026 09:07
@MathurAditya724 MathurAditya724 requested a review from Lms24 January 29, 2026 09:08
retention-days: 7

- name: Upload test results to Codecov
- name: Compute test coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this job name misleading? We don't compute anything here, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Codecov action we are doing 2 thing -

  1. Parse the coverage report, figure out the current coverage and compare it with the base branch (if the artifact for that branch exists, once this is merged we will have that)
  2. Upload the coverage report to the github artifact store

So I thought this was a good name, but according to you what would be a better name here?

retention-days: 7

- name: Upload test results to Codecov
- name: Compute test coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same Q here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: added support for the new codecov action

3 participants