-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: added support for the new codecov action #18930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| retention-days: 7 | ||
|
|
||
| - name: Upload test results to Codecov | ||
| - name: Compute test coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this job name misleading? We don't compute anything here, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Codecov action we are doing 2 thing -
- Parse the coverage report, figure out the current coverage and compare it with the base branch (if the artifact for that branch exists, once this is merged we will have that)
- Upload the coverage report to the github artifact store
So I thought this was a good name, but according to you what would be a better name here?
| retention-days: 7 | ||
|
|
||
| - name: Upload test results to Codecov | ||
| - name: Compute test coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same Q here
Closes #19076 (added automatically)