Add options.ignoredErrors accepting String and Regex#4083
Merged
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00c8eeb | 415.32 ms | 428.08 ms | 12.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00c8eeb | 1.70 MiB | 2.36 MiB | 671.98 KiB |
Previous results on branch: feat/ignore-exceptions
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27b404c | 402.96 ms | 465.55 ms | 62.59 ms |
| 8b85eaa | 438.47 ms | 462.70 ms | 24.23 ms |
| 8011314 | 398.27 ms | 475.16 ms | 76.88 ms |
| d7c436a | 447.47 ms | 513.85 ms | 66.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 27b404c | 1.65 MiB | 2.31 MiB | 678.18 KiB |
| 8b85eaa | 1.65 MiB | 2.31 MiB | 677.69 KiB |
| 8011314 | 1.65 MiB | 2.31 MiB | 677.69 KiB |
| d7c436a | 1.65 MiB | 2.31 MiB | 677.88 KiB |
adinauer
reviewed
Jan 22, 2025
226f075 to
82b9faf
Compare
…eral possible messages as in the JS SDK and not on only on the Exception class
adinauer
reviewed
Jan 24, 2025
Member
adinauer
left a comment
There was a problem hiding this comment.
Mostly looks good already, we should agree on an order of evaluation for the filtering and keep it consistent across events being checked.
options.ignoreExceptions accepting String and Regexoptions.ignoredErrors accepting String and Regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds an option
ignoredErrors(calledignoreErrorsin other SDKs) to ignore Errors matching a certain String or Regex💡 Motivation and Context
Closes #3471
💚 How did you test it?
Unit tests for Client, Options and ExternalOptions
📝 Checklist
sendDefaultPIIis enabled.