Avoid logging an error when a float is passed in the manifest#4031
Merged
stefanosiano merged 5 commits intomainfrom Jan 22, 2025
Merged
Avoid logging an error when a float is passed in the manifest#4031stefanosiano merged 5 commits intomainfrom
stefanosiano merged 5 commits intomainfrom
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00c8eeb | 415.32 ms | 428.08 ms | 12.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00c8eeb | 1.70 MiB | 2.36 MiB | 671.98 KiB |
Previous results on branch: fix/avoid-log-floats
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8afb0d4 | 450.78 ms | 483.59 ms | 32.80 ms |
| 9e5d3c8 | 465.39 ms | 493.20 ms | 27.81 ms |
| ecbb096 | 389.02 ms | 456.79 ms | 67.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8afb0d4 | 1.65 MiB | 2.31 MiB | 677.57 KiB |
| 9e5d3c8 | 1.65 MiB | 2.31 MiB | 677.59 KiB |
| ecbb096 | 1.65 MiB | 2.31 MiB | 677.59 KiB |
romtsn
approved these changes
Jan 16, 2025
Member
|
@stefanosiano @adinauer wanted to hold off with merging PRs to v8, so you could wait until next week (or convince Alex :)) to merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Avoid logging an error when a float is passed in the manifest
#3823 added support for integer values in the manifest.
But that's used as default value when parsing floats. This means that all float values are evaluated as integers and floats, causing one of the checks to fail.
Everything still works correctly, but when the type is wrong, the error is logged in the logcat.
This PR avoids the log if the value passed in the manifest is a float
💡 Motivation and Context
Closes getsentry/sentry-android-gradle-plugin#803
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps