Create onCreate and onStart spans for all Activities#4025
Merged
Conversation
…s, not only for appStart ones
Contributor
|
Contributor
Author
|
Just a note: Also, this works for automatic transactions only. If we want to instrument custom transactions, we can easily use |
Contributor
Performance metrics 🚀
|
romtsn
approved these changes
Feb 6, 2025
Member
|
removed "closes" because that issue was about adding onResume spans which this PR does not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
ActivityLifecycleIntegration creates activity spans for all Activities, not only for appStart ones.
💡 Motivation and Context
We are currently adding
onCreateandonStartspans only in the app start transaction. This PR will add these spans to all automatic transactions, too💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps