POTEL 70 - Add sentry-opentelemetry-agentless-spring module#4000
Merged
POTEL 70 - Add sentry-opentelemetry-agentless-spring module#4000
sentry-opentelemetry-agentless-spring module#4000Conversation
…the ScopesStorage is initialized
adinauer
requested review from
markushi,
romtsn and
stefanosiano
as code owners
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 70 - Add `sentry-opentelemetry-agentless-spring` module ([#4000](https://github.com/getsentry/sentry-java/pull/4000))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
lbloder
approved these changes
Dec 20, 2024
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
LGTM 👍
Left one suggestion and a question
| options -> { | ||
| options.setDsn("..."); | ||
| ... | ||
| OpenTelemetryUtil.applyOpenTelemetryOptions(options, false); |
Collaborator
There was a problem hiding this comment.
This can be removed, as it is now obsolete. I suggest we do that in the #3978 PR
Comment on lines
+14
to
+17
| api(Config.Libs.OpenTelemetry.otelSdk) | ||
| api(Config.Libs.OpenTelemetry.otelSemconv) | ||
| api(Config.Libs.OpenTelemetry.otelSemconvIncubating) | ||
| api(Config.Libs.OpenTelemetry.otelExtensionAutoconfigure) |
Collaborator
There was a problem hiding this comment.
Are we not depending on the sentry-opentelemetry-agentless module because of the AgentlessMarker?
Member
Author
There was a problem hiding this comment.
Yeah, I thought, it might cause more issues than save work to reuse the other agentless module here since there's very little in both currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
sentry-opentelemetry-agentless-springmodule💡 Motivation and Context
So we can bring the right version of
opentelemetry-spring-boot-starterand also add a marker which can then later be detected for auto configuration.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps