Skip to content

Conversation

@sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Dec 17, 2025

@sommerfe sommerfe self-assigned this Dec 17, 2025
@sommerfe sommerfe force-pushed the fix-pb-2064-cesium-cypress branch from 2016ece to 2a4b70c Compare December 17, 2025 10:43
@github-actions github-actions bot added the bug label Dec 17, 2025
@sommerfe sommerfe requested review from ltkum and pakb December 17, 2025 10:43
@sommerfe sommerfe force-pushed the fix-pb-2064-cesium-cypress branch 4 times, most recently from f7ded02 to beb5368 Compare December 17, 2025 14:48
@cypress
Copy link

cypress bot commented Dec 17, 2025

web-mapviewer    Run #6310

Run Properties:  status check failed Failed #6310  •  git commit ceb4c438bd: PB-2064: add launch options webgl
Project web-mapviewer
Branch Review fix-pb-2064-cesium-cypress
Run status status check failed Failed #6310
Run duration 17m 53s
Commit git commit ceb4c438bd: PB-2064: add launch options webgl
Committer Felix Sommer
View all properties for this run ↗︎

Test results
Tests that failed  Failures 49
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 198
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.ts • 14 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create annotation/text and edit them Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line / measurement, extend it, and delete the last node by right click / button, and make a polygon Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line/polygons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > KML management > receives an empty KML and can use drawing mode Test Replay Screenshots
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.
Failed  legacyParamImport.cy.ts • 6 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers Test Replay Screenshots
Test on legacy param import > Layers import > doesn't show encoding in the search bar when serving a swisssearch legacy url Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading Test Replay Screenshots
... > Select a few features and shows the tooltip in its correct spot Test Replay Screenshots
Failed  3d/layers.cy.ts • 10 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Test of layer handling in 3D > add layer from search bar Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing Test Replay Screenshots
Test of layer handling in 3D > Verify layer features in 2D and 3D Test Replay Screenshots
Test of layer handling in 3D > Verify a layer with EPSG:4326(WEBMERCATOR) bounding box in 2D and 3D Test Replay Screenshots
Failed  featureSelection.cy.ts • 4 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information Test Replay Screenshots
Failed  shareShortLink.cy.ts • 2 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Testing the share menu > iFrame snippet generation > enables the user to tick the zoom checkbox and require ctrl/cmd to zoom Test Replay Screenshots
Testing the share menu > iFrame snippet generation after loading local file > shows the warning of sharing an iframe while having a local file imported Test Replay Screenshots

The first 5 failed specs are shown, see all 16 specs in Cypress Cloud.

@sommerfe
Copy link
Contributor Author

@pakb @ltkum I saw that the 3D tests are failing with an error that the webgl still does not work, this might be a problem that the CI runs the tests with Chrome 142 but 143 is needed. Is this configurable somewhere?

Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need some rebasing before I give it a look

@sommerfe sommerfe force-pushed the fix-pb-2064-cesium-cypress branch from ceb4c43 to 1f48c4d Compare January 8, 2026 07:11
@sommerfe sommerfe force-pushed the fix-pb-2064-cesium-cypress branch from 1f48c4d to 2a77499 Compare January 8, 2026 08:34
@sommerfe sommerfe requested a review from pakb January 8, 2026 12:12
// To avoid this, we can pass the --disable-gpu flag.
launchOptions.args.push('--disable-gpu')
} else {
// For the headed mode, ensure WebGL is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headless not headed 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case it is not headless mode, not sure if headed is the best word for it :D

Comment on lines +120 to +122

// Return the modified config from the plugin
return updatedConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't modify it, do you?
Might be some remnant of some attempt at fixing the problem by changing the config.
Can you revert that back to the old code if it's not required? (moving the use of cypressBrowserPermissionsPlugin at the same spot and all)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required, if the cypressBrowserPermissionsPlugin is created like before the on functions are not executed, this means there are no launch options set which makes cesium not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants