-
Notifications
You must be signed in to change notification settings - Fork 16
PB-2064: fix cesium cypress #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-PB-1383-pinia-store
Are you sure you want to change the base?
Conversation
2016ece to
2a4b70c
Compare
f7ded02 to
beb5368
Compare
pakb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need some rebasing before I give it a look
ceb4c43 to
1f48c4d
Compare
1f48c4d to
2a77499
Compare
| // To avoid this, we can pass the --disable-gpu flag. | ||
| launchOptions.args.push('--disable-gpu') | ||
| } else { | ||
| // For the headed mode, ensure WebGL is enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headless not headed 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case it is not headless mode, not sure if headed is the best word for it :D
|
|
||
| // Return the modified config from the plugin | ||
| return updatedConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't modify it, do you?
Might be some remnant of some attempt at fixing the problem by changing the config.
Can you revert that back to the old code if it's not required? (moving the use of cypressBrowserPermissionsPlugin at the same spot and all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required, if the cypressBrowserPermissionsPlugin is created like before the on functions are not executed, this means there are no launch options set which makes cesium not work.
Test link