Performance of calculateCellHeights #235
Open
+54
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
When rendering large datasets that contain newline characters, there is significant performance degradation.
This is caused by excessive GC pressure due to unnecessary
.split()and.splice()operations during wrapping and height calculations.🧪 Current Workaround
To mitigate the issue in production use, I implemented a lazy-loading approach for rendering tables (e.g., recent traceback list), loading content in parts and merging the final table at runtime.
✅ Proposed Solution
Optimize the height calculation logic by using a regex
.exec()in a loop instead of.split()and.wrap()to count line breaks.This avoids allocating large arrays and reduces GC overhead during render-heavy scenarios.
🔍 What Could Be Improved
wrap*functions could be reviewed and optimized for better performance.