Fix header and footer in rtl body direction#56
Open
ahmed-madi wants to merge 3 commits intofrappe:masterfrom
Open
Fix header and footer in rtl body direction#56ahmed-madi wants to merge 3 commits intofrappe:masterfrom
ahmed-madi wants to merge 3 commits intofrappe:masterfrom
Conversation
|
i test it locally it works fine with me .. |
ahmadRagheb
approved these changes
Feb 24, 2019
|
@netchampfaris what do you think? |
|
@ahmed-madi there is issue when change the col size it do the ltr not rtl adjustment |
ahmadRagheb
suggested changes
Mar 2, 2019
ahmadRagheb
left a comment
There was a problem hiding this comment.
when change the size of columns it goes to LTR not RTL
Author
Please give scenario with steps to reproduce |
|
@ahmed-madi i try to make some columns width changes so in RTL the same direction as LTR in width addition .. it should go to right not left |
|
@ahmadRagheb Could You fix the Conflicting files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header and footer don't scroll when the body is in rtl direction, and this is because of the different value of scrollLeft in different browsers when the direction is rtl, also - sign should be inside the Template string like this ${-scrollLeft} to be calculated properly in case of rtl body direction because Firefox calculates the value of the scrollLeft in negative when the direction is rtl so translateX need a positive value to move as expected. this pull request fix these issues.
Thank you