[3.41] Updated fragment shader api to reflect new uniform-by-name accessors.#12556
Open
gaaclarke wants to merge 1 commit intoflutter:mainfrom
Open
[3.41] Updated fragment shader api to reflect new uniform-by-name accessors.#12556gaaclarke wants to merge 1 commit intoflutter:mainfrom
gaaclarke wants to merge 1 commit intoflutter:mainfrom
Conversation
Collaborator
|
Visit the preview URL for this PR (updated for commit 0174d55): https://flutter-docs-prod--pr12556-uniform-by-name-ol1x2zt1.web.app |
Contributor
|
@gaaclarke, it looks like it's on stable now? If so, can you remove from draft and land? |
Member
Author
|
Nope, not yet. It still isn't on stable: https://github.com/flutter/flutter/blob/b45fa18946ecc2d9b4009952c636ba7e2ffbb787/engine/src/flutter/lib/ui/painting.dart#L5283 |
Contributor
|
Don't land until the next stable release, but this doesn't need to be in draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT LAND UNTIL flutter/flutter#176417 IS ON STABLE
Description of what this PR is changing or adding, and why:
Updated documentation to take advantage of new easier api.
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
flutter/flutter#176417
Presubmit checklist
of 80 characters or fewer.