You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disable flutter_portal tests. The flutter_portal CI runs on an old Flutter SDK (3.10.0) and does not support patches on the current main channel Flutter SDK.
The upstream repository that hosts the tests must be able to receive patches to support the main channel of Flutter. This means that CI on the upstream repository should use the main channel Flutter SDK.
@fzyzcjy this showed up because the customer tests script automatically runs dart fix on customer tests with the main channel. withOpacity() was replaced with withValues(alpha:) which has slightly different rounding logic for things like 0.5 which don't map cleaning into the 0-255 space. We tried to forward fix the test for you, but we couldn't because the tests are running against a pegged old version of Flutter, 3.10 which doesn't have access to the new API. Ultimately, running tests against channels other than main is a violation of the rules to being subscribed to customer tests as b-luk stated.
The easiest way to get these tests reenabled is to switch your github actions to work against the main channel instead. For your own testing against 3.10 and stable you'll have to move them into a different github action that isn't triggered by Flutter's customer testing.
Hi, thanks for pinging me! Unfortunately I have a very tight DDL recently and do not have time to update it :( Feel free to just disable it currently and I will handle it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable flutter_portal tests. The flutter_portal CI runs on an old Flutter SDK (3.10.0) and does not support patches on the current main channel Flutter SDK.
From https://github.com/flutter/tests/blob/main/README.md:
@fzyzcjy