Upgrade android_splash_screen Gradle configuration#2779
Open
NiazSagor wants to merge 4 commits intoflutter:mainfrom
Open
Upgrade android_splash_screen Gradle configuration#2779NiazSagor wants to merge 4 commits intoflutter:mainfrom
NiazSagor wants to merge 4 commits intoflutter:mainfrom
Conversation
This commit modernizes the Gradle setup for the `android_splash_screen` sample. Key changes include: * Upgrading Gradle wrapper from version 6.7 to 8.7. * Migrating to the plugins block in `settings.gradle` and `app/build.gradle` for applying Android, Kotlin, and Flutter Gradle plugins. * Removing the outdated `buildscript` block from the root `build.gradle`. * Updating `compileSdkVersion` and `targetSdkVersion` to 34. * Setting `minSdkVersion` to `flutter.minSdkVersion`. * Adding the `namespace` property as required by newer Android Gradle Plugin versions. * Refactoring Kotlin constant declarations in `MainActivity.kt`.
Collaborator
|
Increible, thank you @NiazSagor -- I'm running CI now. (CI might be broken, I'm investigating) |
Author
|
Thank You!! for the review. I am more than Happy to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
android_splash_screensample was outdated and was not runnable due to gradle issues.This commit fixes the Gradle setup for the
android_splash_screensample.Key changes include:
settings.gradleandapp/build.gradlefor applying Android, Kotlin, and Flutter Gradle plugins.buildscriptblock from the rootbuild.gradle.compileSdkVersionandtargetSdkVersionto 34.minSdkVersiontoflutter.minSdkVersion.namespaceproperty as required by newer Android Gradle Plugin versions.MainActivity.kt.@ericwindmill
Pre-launch Checklist
///).