[google_maps_flutter_android] Batch clustered marker operations#10940
Open
elitree wants to merge 5 commits intoflutter:mainfrom
Open
[google_maps_flutter_android] Batch clustered marker operations#10940elitree wants to merge 5 commits intoflutter:mainfrom
elitree wants to merge 5 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces batch operations for clustered markers to improve performance, which is a great enhancement. The changes involve adding addItems() and removeItems() methods to ClusterManagersController and refactoring MarkersController to group marker operations by cluster manager and execute them in batches. The new logic is well-tested with new unit tests. My review includes a few suggestions to use Map.computeIfAbsent in MarkersController for more concise and modern Java code.
...s_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Outdated
Show resolved
Hide resolved
...s_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Outdated
Show resolved
Hide resolved
...s_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Outdated
Show resolved
Hide resolved
...s_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Outdated
Show resolved
Hide resolved
22e3623 to
22037dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR attempts to use the same strategy from the Google Maps Flutter Web PR #10562 and apply it to Google Maps Flutter Android.
Summary
addItems()andremoveItems()methods toClusterManagersControllerMarkersControllerto batch add/remove/change operations for clustered markersThis improves performance when working with large numbers of clustered markers by calling
ClusterManager.cluster()once per cluster manager instead of once per marker.Test plan
Addresses flutter/flutter#170573
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.🤖 Generated with Claude Code
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3