Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/devtools_shared/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ Copyright 2025 The Flutter Authors
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
-->
# 12.1.0
* Adds additional logging to `IntegrationTestRunner`.
* Fixes assertion error when parsing Flutter channel versions using the format `X.XX.X-X.X.pre-XXX`.
* Fixes breakage associated with ChromeDriver 138 when using `IntegrationTestRunner`.
* Adds `sanitizeVersionStr` helper to `SemanticVersion`.
* Fixes null error when parsing `bundleIdentifier` or `teamIndentifier` in `UniversalLinkSettings`.

# 12.0.0
* Update `dtd` dependency to `^4.0.0`.
* Register and unregister VM service connections on DTD. This change only
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ extension type const UniversalLinkSettings._(Map<String, Object?> _json) {
});

/// The bundle identifier of the iOS build of this Flutter project.
String? get bundleIdentifier => _json[_kBundleIdentifierKey] as String?;
String get bundleIdentifier =>
(_json[_kBundleIdentifierKey] as String?) ?? '';

/// The team identifier of the iOS build of this Flutter project.
String? get teamIdentifier => _json[_kTeamIdentifierKey] as String?;
String get teamIdentifier => (_json[_kTeamIdentifierKey] as String?) ?? '';

/// The associated domains of the iOS build of this Flutter project.
List<String> get associatedDomains =>
Expand Down
4 changes: 2 additions & 2 deletions packages/devtools_shared/lib/src/test/io_utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ mixin IOMixin {
Process.killPid(processId);
return process.exitCode.timeout(
killTimeout,
onTimeout: () => _killForcefully(process, debugLogging: debugLogging),
onTimeout: () => killForcefully(process, debugLogging: debugLogging),
);
}

Future<int> _killForcefully(
Future<int> killForcefully(
Process process, {
bool debugLogging = false,
}) {
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_shared/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
name: devtools_shared
description: Package of shared Dart structures between devtools_app, dds, and other tools.

version: 12.0.0
version: 12.1.0

repository: https://github.com/flutter/devtools/tree/master/packages/devtools_shared

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void main() {
}
''';
final settings = UniversalLinkSettings.fromJson(json);
expect(settings.bundleIdentifier, isNull);
expect(settings.bundleIdentifier, isEmpty);
expect(settings.teamIdentifier, 'TEAMID');
expect(settings.associatedDomains, ['applinks:example.com']);
});
Expand All @@ -43,7 +43,7 @@ void main() {
''';
final settings = UniversalLinkSettings.fromJson(json);
expect(settings.bundleIdentifier, 'com.example.app');
expect(settings.teamIdentifier, isNull);
expect(settings.teamIdentifier, isEmpty);
expect(settings.associatedDomains, ['applinks:example.com']);
});
});
Expand Down
Loading