Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates all iOS plugin implementations from Objective-C to Swift, modernizing the codebase and improving maintainability. The migration covers 20+ ML Kit plugins and common infrastructure.
Changes:
- Migrated all iOS plugin code from Objective-C (.m/.h) to Swift (.swift)
- Updated podspec files to reference Swift files only and changed author to 'flutter-ml.dev'
- Added SwiftLint integration to analyze.sh and GitHub Actions workflow
- Updated Xcode project configuration and removed test targets
- Maintained API compatibility with existing Flutter/Dart interfaces
Reviewed changes
Copilot reviewed 102 out of 125 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/analyze.sh | Added SwiftLint checks for iOS Swift code |
| .github/workflows/code-analysis.yml | Added SwiftLint installation and execution |
| packages//ios/.podspec | Updated to reference Swift files, removed header files |
| packages//ios/Classes/.swift | New Swift implementations of all plugins |
| packages//ios/Classes/.m/*.h | Removed Objective-C implementations |
| packages/google_mlkit_commons/ios/Classes/ | Core infrastructure migrated to Swift |
| packages/example/ios/*.pbxproj | Xcode project updates, removed test targets |
| .run/*.xml | Added Flutter run configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_entity_extraction/ios/Classes/GoogleMlKitEntityExtractionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_text_recognition/ios/Classes/GoogleMlKitTextRecognitionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_commons/ios/Classes/MLKVisionImage+FlutterPlugin.swift
Outdated
Show resolved
Hide resolved
...oogle_mlkit_digital_ink_recognition/ios/Classes/GoogleMlKitDigitalInkRecognitionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_barcode_scanning/ios/Classes/GoogleMlKitBarcodeScanningPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_translation/ios/Classes/GoogleMlKitTranslationPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_object_detection/ios/Classes/GoogleMlKitObjectDetectionPlugin.swift
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
3 times, most recently
from
b840a41 to
cb32b36
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 103 out of 126 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_object_detection/ios/Classes/GoogleMlKitObjectDetectionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_image_labeling/ios/Classes/GoogleMlKitImageLabelingPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_face_detection/ios/Classes/GoogleMlKitFaceDetectionPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_text_recognition/ios/Classes/GoogleMlKitTextRecognitionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_entity_extraction/ios/Classes/GoogleMlKitEntityExtractionPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_barcode_scanning/ios/Classes/GoogleMlKitBarcodeScanningPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_commons/ios/Classes/MLKVisionImage+FlutterPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_translation/ios/Classes/GoogleMlKitTranslationPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_entity_extraction/ios/Classes/GoogleMlKitEntityExtractionPlugin.swift
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
5 times, most recently
from
9e772d2 to
9153ce0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_face_detection/ios/Classes/GoogleMlKitFaceDetectionPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_barcode_scanning/ios/Classes/GoogleMlKitBarcodeScanningPlugin.swift
Outdated
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
from
9153ce0 to
398e810
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_barcode_scanning/ios/Classes/GoogleMlKitBarcodeScanningPlugin.swift
Outdated
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
from
398e810 to
6d510a4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_image_labeling/ios/Classes/GoogleMlKitImageLabelingPlugin.swift
Show resolved
Hide resolved
packages/google_mlkit_commons/ios/Classes/GenericModelManager.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_object_detection/ios/Classes/GoogleMlKitObjectDetectionPlugin.swift
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
from
6d510a4 to
819a47c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbernaly
force-pushed
the
swift_migration
branch
from
819a47c to
0e38361
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_commons/ios/Classes/GenericModelManager.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_barcode_scanning/ios/Classes/GoogleMlKitBarcodeScanningPlugin.swift
Outdated
Show resolved
Hide resolved
packages/google_mlkit_commons/ios/Classes/MLKVisionImage+FlutterPlugin.swift
Outdated
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
from
0e38361 to
89d4e5a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 108 out of 131 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/google_mlkit_commons/ios/Classes/MLKVisionImage+FlutterPlugin.swift
Outdated
Show resolved
Hide resolved
fbernaly
force-pushed
the
swift_migration
branch
from
89d4e5a to
9d3c289
Compare
1 participant
No description provided.