test_yaml_parser: add tests for YAML parser #5224
Open
+563
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
add-yaml-parser-test
branch
5 times, most recently
from
6b2ede6 to
7575ad1
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
add-yaml-parser-test
branch
from
7575ad1 to
6399577
Compare
Watson1978
added
the
backport to v1.19
kenhys
requested changes
Jan 9, 2026
| File.open(path, "w:#{encoding}:utf-8") {|f| f.write data } | ||
| end | ||
|
|
||
| def test_special_yaml_elements_dollar |
Contributor
There was a problem hiding this comment.
It might be better to group with sub_test-case
| assert_equal("match", config.elements[2].name) | ||
| assert_equal("worker", config.elements[3].name) | ||
| assert_equal("label", config.elements[4].name) | ||
| assert_equal("filter", config.elements[5].name) # included section |
Contributor
There was a problem hiding this comment.
It could be simplified with:
assert_equal(%w(source filter match worker label filter), config.elements.map(&:name))
| config = Fluent::Config::YamlParser.parse("#{TMP_DIR}/test_merge_common_parameter_using_include.yaml") | ||
| assert_equal(2, config.elements.size) | ||
| assert_equal('foobarbaz', config.elements[0].elements[0]['common_param']) | ||
| assert_equal('foobarbaz', config.elements[1].elements[0]['common_param']) |
Contributor
There was a problem hiding this comment.
elements[X].elements[Y]で参照するのはおそらく意図したものではなさそう。
現状パースエラーになるけど、以下をincludeするものとしたテストコードであるべきじゃないだろうか。
https://docs.fluentd.org/configuration/config-file-yaml#share-the-same-parameters
write_config "#{TMP_DIR}/fluent-common.yaml", <<~EOS
common_param: foobarbaz
EOS
Contributor
There was a problem hiding this comment.
たとえば、テストケースのconfig.elements[0]は以下のように現状ではパースされる。
<name:match, arg:dummy_tag_1, attrs:{...}, elements:[<name:<<, arg:, attrs:{"common_param" => "foobarbaz"}, elements:[]>]>
config.elements[0].elements[0].name == '<<'になってしまっている。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
This PR will add missing yaml parser tests.
Docs Changes:
Release Note: