Skip to content

log: Use proper ISO 8601 format for logging#11463

Open
michael-o wants to merge 1 commit intofluent:masterfrom
michael-o:iso-8601-log-fix
Open

log: Use proper ISO 8601 format for logging#11463
michael-o wants to merge 1 commit intofluent:masterfrom
michael-o:iso-8601-log-fix

Conversation

@michael-o
Copy link

@michael-o michael-o commented Feb 14, 2026

Instead of using a custom format, use proper extended ISO 8601 datetime format.

Change is straight forward. Output now:

root@135-release-amd64-default-head:/usr/ports/sysutils/fluent-bit # fluent-bit
Fluent Bit v4.2.2
* Copyright (C) 2015-2025 The Fluent Bit Authors
* Fluent Bit is a CNCF graduated project under the Fluent organization
* https://fluentbit.io

______ _                  _    ______ _ _             ___   _____
|  ___| |                | |   | ___ (_) |           /   | / __  \
| |_  | |_   _  ___ _ __ | |_  | |_/ /_| |_  __   __/ /| | `' / /'
|  _| | | | | |/ _ \ '_ \| __| | ___ \ | __| \ \ / / /_| |   / /
| |   | | |_| |  __/ | | | |_  | |_/ / | |_   \ V /\___  |_./ /___
\_|   |_|\__,_|\___|_| |_|\__| \____/|_|\__|   \_/     |_(_)_____/

             Fluent Bit v4.2 – Direct Routes Ahead
         Celebrating 10 Years of Open, Fluent Innovation!

[2026-02-14 16:48:08.479196279] [ info] [fluent bit] version=4.2.2, commit=, pid=51299
[2026-02-14 16:48:08.479304309] [ info] [storage] ver=1.5.4, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2026-02-14 16:48:08.479316303] [ info] [simd    ] disabled
[2026-02-14 16:48:08.479331868] [ info] [cmetrics] version=1.0.6
[2026-02-14 16:48:08.479341850] [ info] [ctraces ] version=0.6.6
[2026-02-14 16:48:08.479426082] [ info] [sp] stream processor started
[2026-02-14 16:48:08.479455774] [ info] [engine] Shutdown Grace Period=5, Shutdown Input Grace Period=2
^C[2026/02/14 16:48:14] [engine] caught signal (SIGINT)
[2026-02-14 16:48:14.437349155] [ warn] [engine] service will shutdown in max 5 seconds
[2026-02-14 16:48:14.437375002] [ info] [engine] pausing all inputs..
[2026-02-14 16:48:15.437451218] [ info] [engine] service has stopped (0 pending tasks)
root@135-release-amd64-default-head:/usr/ports/sysutils/fluent-bit #

Summary by CodeRabbit

  • Style
    • Standardized date separator in visible timestamps from YYYY/MM/DD to YYYY-MM-DD across runtime log output, dump headers, and status/signal messages to present consistent, hyphen-separated dates in emitted logs and diagnostics.

@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Date separators in log and dump timestamp format strings were changed from slashes (/) to dashes (-) across three source files; no other logic, control flow, or API changes were made.

Changes

Cohort / File(s) Summary
Date format updates
src/flb_log.c, src/flb_dump.c, src/fluent-bit.c
Replaced '/' with '-' in timestamp/date format strings used for log, dump, and signal/status prefixes (e.g., YYYY/MM/DD -> YYYY-MM-DD). No functional, error-handling, or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny hop to tweak the date,
Slashes swapped so logs look straight,
Dashes line the morning light,
Timestamps tidy, neat, and bright,
I nibble code — and dance with delight!

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting log timestamp formatting from custom format with slashes (YYYY/MM/DD) to ISO 8601 format with hyphens (YYYY-MM-DD) across multiple files.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c429e5ee1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Instead of using a custom format, use proper extended ISO 8601 datetime format.

Signed-off-by: Michael Osipov <michael.osipov@innomotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments