Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #xxx

Change Log


Added

Fixed

Changed

  • split query and result exception in postgresql client

Removed

Deprecated

Security

- QueryException received more details about error
- errors related to result itself now are thrown as ResultException
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
| benchmark                | subject                        | revs | its | mem_peak        | mode               | rstdev          |
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
| CSVExtractorBench        | bench_extract_10k              | 1    | 1   | 5.799mb +0.01%  | 658.419ms +119.62% | ±0.00% -100.00% |
| DbalExtractorBench       | bench_extract_10k_keyset       | 1    | 1   | 35.133mb +0.02% | 502.502ms +136.78% | ±0.00% -100.00% |
| DbalExtractorBench       | bench_extract_10k_limit_offset | 1    | 1   | 35.145mb -0.09% | 559.442ms +203.05% | ±0.00% -100.00% |
| ExcelExtractorBench      | bench_extract_10k_ods          | 1    | 1   | 48.751mb +0.00% | 2.127s +127.47%    | ±0.00% -100.00% |
| ExcelExtractorBench      | bench_extract_10k_xlsx         | 1    | 1   | 49.614mb +0.00% | 3.111s +96.15%     | ±0.00% -100.00% |
| JsonExtractorBench       | bench_extract_10k              | 1    | 1   | 6.524mb +0.01%  | 2.077s +89.29%     | ±0.00% -100.00% |
| ParquetExtractorBench    | bench_extract_10k              | 1    | 1   | 11.777mb -0.15% | 15.163s +25.53%    | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_cursor       | 1    | 1   | 37.592mb +0.07% | 265.330ms +15.34%  | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_keyset       | 1    | 1   | 37.604mb +0.05% | 438.344ms +3.37%   | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_limit_offset | 1    | 1   | 37.588mb +0.05% | 385.250ms +1.15%   | ±0.00% -100.00% |
| TextExtractorBench       | bench_extract_10k              | 1    | 1   | 5.798mb +0.01%  | 55.581ms +1.81%    | ±0.00% -100.00% |
| XmlExtractorBench        | bench_extract_10k              | 1    | 1   | 5.818mb +0.01%  | 676.909ms +1.80%   | ±0.00% -100.00% |
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode               | rstdev          |
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 1   | 124.670mb +0.00% | 165.832ms +128.67% | ±0.00% -100.00% |
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 1   | 19.864mb +0.00%  | 149.232ms +103.15% | ±0.00% -100.00% |
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
Loaders
+-----------------------+---------------------+------+-----+------------------+--------------------+-----------------+
| benchmark             | subject             | revs | its | mem_peak         | mode               | rstdev          |
+-----------------------+---------------------+------+-----+------------------+--------------------+-----------------+
| CSVLoaderBench        | bench_load_10k      | 1    | 1   | 47.953mb +0.00%  | 175.724ms +149.08% | ±0.00% -100.00% |
| DbalLoaderBench       | bench_load_10k      | 1    | 1   | 35.094mb -0.02%  | 2.608s +127.93%    | ±0.00% -100.00% |
| ExcelLoaderBench      | bench_load_10k_ods  | 1    | 1   | 6.729mb +0.01%   | 3.078s +100.97%    | ±0.00% -100.00% |
| ExcelLoaderBench      | bench_load_10k_xlsx | 1    | 1   | 11.397mb +0.00%  | 4.092s +72.56%     | ±0.00% -100.00% |
| JsonLoaderBench       | bench_load_10k      | 1    | 1   | 82.785mb +0.00%  | 176.306ms +64.45%  | ±0.00% -100.00% |
| ParquetLoaderBench    | bench_load_10k      | 1    | 1   | 794.693mb +0.01% | 18.990s -27.41%    | ±0.00% -100.00% |
| PostgreSqlLoaderBench | bench_load_10k      | 1    | 1   | 37.586mb +0.07%  | 863.138ms +0.49%   | ±0.00% -100.00% |
| TextLoaderBench       | bench_load_10k      | 1    | 1   | 19.253mb +0.00%  | 35.312ms +0.25%    | ±0.00% -100.00% |
+-----------------------+---------------------+------+-----+------------------+--------------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode               | rstdev          |
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 107.266mb +0.00% | 1.161s +117.30%    | ±0.00% -100.00% |
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 56.663mb +0.00%  | 597.546ms +119.45% | ±0.00% -100.00% |
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 16.345mb +0.00%  | 108.042ms +79.21%  | ±0.00% -100.00% |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 1   | 95.165mb +0.00%  | 14.567ms +242.61%  | ±0.00% -100.00% |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 1   | 112.559mb +0.00% | 657.248ms +167.76% | ±0.00% -100.00% |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 1   | 95.279mb +0.00%  | 45.597ms +81.47%   | ±0.00% -100.00% |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 1   | 96.040mb +0.00%  | 3.996ms +103.41%   | ±0.00% -100.00% |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 1   | 96.040mb +0.00%  | 2.448ms +38.10%    | ±0.00% -100.00% |
| RowsBench         | bench_entries_on_10k       | 2    | 1   | 94.201mb +0.00%  | 5.132ms +31.99%    | ±0.00% -100.00% |
| RowsBench         | bench_filter_on_10k        | 2    | 1   | 94.730mb +0.00%  | 32.534ms +70.41%   | ±0.00% -100.00% |
| RowsBench         | bench_find_on_10k          | 2    | 1   | 94.730mb +0.00%  | 30.517ms +57.63%   | ±0.00% -100.00% |
| RowsBench         | bench_find_one_on_10k      | 10   | 1   | 93.418mb +0.00%  | 4.600μs +119.68%   | ±0.00% -100.00% |
| RowsBench         | bench_first_on_10k         | 10   | 1   | 93.418mb +0.00%  | 0.400μs 0.00%      | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 1   | 102.479mb +0.00% | 28.847ms +77.41%   | ±0.00% -100.00% |
| RowsBench         | bench_map_on_10k           | 2    | 1   | 131.906mb +0.00% | 135.860ms +82.75%  | ±0.00% -100.00% |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 1   | 95.249mb +0.00%  | 3.065ms +83.23%    | ±0.00% -100.00% |
| RowsBench         | bench_partition_by_on_10k  | 2    | 1   | 98.641mb +0.00%  | 121.571ms +93.69%  | ±0.00% -100.00% |
| RowsBench         | bench_remove_on_10k        | 2    | 1   | 96.302mb +0.00%  | 7.850ms +110.64%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 1   | 93.803mb +0.00%  | 80.458ms +93.01%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_by_on_1k        | 2    | 1   | 93.803mb +0.00%  | 77.821ms +79.33%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 1   | 93.803mb +0.00%  | 77.066ms +81.01%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 1   | 95.861mb +0.00%  | 15.584ms +74.53%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_on_1k           | 2    | 1   | 93.611mb +0.00%  | 57.436ms +77.72%   | ±0.00% -100.00% |
| RowsBench         | bench_take_1k_on_10k       | 10   | 1   | 93.418mb +0.00%  | 31.200μs +126.42%  | ±0.00% -100.00% |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 1   | 93.418mb +0.00%  | 37.900μs +122.00%  | ±0.00% -100.00% |
| RowsBench         | bench_unique_on_1k         | 2    | 1   | 112.560mb +0.00% | 452.852ms +84.86%  | ±0.00% -100.00% |
| TypeDetectorBench | bench_type_detector        | 1    | 1   | 43.526mb +0.00%  | 614.582ms +82.29%  | ±0.00% -100.00% |
| TypeDetectorBench | bench_type_detector        | 1    | 1   | 12.584mb +0.00%  | 124.605ms +82.71%  | ±0.00% -100.00% |
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
Parquet Library
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark          | subject                         | revs | its | mem_peak         | mode               | rstdev          |
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+
| ParquetWriterBench | bench_write_batch               | 1    | 1   | 12.696mb -12.71% | 361.118ms +59.19%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_gzip                | 1    | 1   | 11.356mb +0.02%  | 419.606ms +89.80%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_row_by_row          | 1    | 1   | 12.696mb -12.71% | 351.572ms +54.99%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_snappy              | 1    | 1   | 12.696mb -12.71% | 412.831ms +83.11%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_uncompressed        | 1    | 1   | 11.080mb +0.02%  | 398.299ms +103.37% | ±0.00% -100.00% |
| ParquetReaderBench | bench_page_headers              | 1    | 1   | 7.823mb +0.01%   | 4.390s +132.40%    | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_metadata             | 1    | 1   | 6.518mb +0.01%   | 16.907ms +106.64%  | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_schema               | 1    | 1   | 6.518mb +0.01%   | 15.223ms +82.13%   | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_all_columns   | 1    | 1   | 10.094mb -0.18%  | 10.735s +36.52%    | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_single_column | 1    | 1   | 7.391mb -0.25%   | 405.586ms -9.39%   | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_with_limit    | 1    | 1   | 7.919mb -0.39%   | 33.973ms +41.86%   | ±0.00% -100.00% |
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+

@norberttech norberttech merged commit 71a3e69 into 1.x Dec 29, 2025
19 checks passed
@norberttech norberttech deleted the chore/expose-query-exception-error branch December 29, 2025 18:14
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 89.50276% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.00%. Comparing base (6691db8) to head (af65c24).
⚠️ Report is 2 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #2111      +/-   ##
==========================================
+ Coverage   82.70%   83.00%   +0.29%     
==========================================
  Files        1171     1174       +3     
  Lines       41376    41531     +155     
==========================================
+ Hits        34221    34472     +251     
+ Misses       7155     7059      -96     
Components Coverage Δ
etl 90.52% <ø> (+0.89%) ⬆️
cli 85.76% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.44% <ø> (ø)
lib-types 88.98% <ø> (+1.51%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
bridge-filesystem-async-aws 90.95% <ø> (ø)
bridge-filesystem-azure 89.38% <ø> (ø)
bridge-monolog-http 96.89% <ø> (ø)
bridge-openapi-specification 91.50% <ø> (ø)
symfony-http-foundation 72.32% <ø> (ø)
adapter-chartjs 86.33% <ø> (ø)
adapter-csv 89.30% <ø> (ø)
adapter-doctrine 91.50% <ø> (ø)
adapter-elasticsearch 97.02% <ø> (ø)
adapter-google-sheet 97.05% <ø> (ø)
adapter-http 65.94% <ø> (ø)
adapter-json 89.69% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.77% <ø> (ø)
adapter-parquet 79.92% <ø> (ø)
adapter-text 86.84% <ø> (ø)
adapter-xml 82.66% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants