Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #xxx

Change Log


Added

Fixed

Changed

  • updated openspout to accept only latest version

Removed

Deprecated

Security

There are differences between version 4 and 5, mainly around some helper methods that I used while creating the adapter. I don't have enough time to cover support for 4 but if anyone would be interested, feel free to open PR's

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.95%. Comparing base (a2c4195) to head (576a2cc).
⚠️ Report is 2 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #2110      +/-   ##
==========================================
+ Coverage   82.70%   82.95%   +0.24%     
==========================================
  Files        1171     1171              
  Lines       41376    41376              
==========================================
+ Hits        34220    34323     +103     
+ Misses       7156     7053     -103     
Components Coverage Δ
etl 90.52% <ø> (+0.89%) ⬆️
cli 85.76% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.44% <ø> (ø)
lib-types 88.98% <ø> (+1.51%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.95% <ø> (ø)
bridge-filesystem-azure 89.38% <ø> (ø)
bridge-monolog-http 96.89% <ø> (ø)
bridge-openapi-specification 91.50% <ø> (ø)
symfony-http-foundation 72.32% <ø> (ø)
adapter-chartjs 86.33% <ø> (ø)
adapter-csv 89.30% <ø> (ø)
adapter-doctrine 91.50% <ø> (ø)
adapter-elasticsearch 97.02% <ø> (ø)
adapter-google-sheet 97.05% <ø> (ø)
adapter-http 65.94% <ø> (ø)
adapter-json 89.69% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.77% <ø> (ø)
adapter-parquet 79.92% <ø> (ø)
adapter-text 86.84% <ø> (ø)
adapter-xml 82.66% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
| benchmark                | subject                        | revs | its | mem_peak        | mode               | rstdev          |
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
| CSVExtractorBench        | bench_extract_10k              | 1    | 1   | 5.799mb -0.02%  | 623.844ms +109.95% | ±0.00% -100.00% |
| DbalExtractorBench       | bench_extract_10k_keyset       | 1    | 1   | 35.129mb -0.03% | 704.338ms +222.30% | ±0.00% -100.00% |
| DbalExtractorBench       | bench_extract_10k_limit_offset | 1    | 1   | 35.111mb +0.02% | 593.492ms +200.77% | ±0.00% -100.00% |
| ExcelExtractorBench      | bench_extract_10k_ods          | 1    | 1   | 48.751mb -0.00% | 1.961s +108.69%    | ±0.00% -100.00% |
| ExcelExtractorBench      | bench_extract_10k_xlsx         | 1    | 1   | 49.614mb -0.00% | 3.125s +97.27%     | ±0.00% -100.00% |
| JsonExtractorBench       | bench_extract_10k              | 1    | 1   | 6.524mb -0.02%  | 1.963s +76.84%     | ±0.00% -100.00% |
| ParquetExtractorBench    | bench_extract_10k              | 1    | 1   | 11.777mb -0.17% | 15.024s +24.57%    | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_cursor       | 1    | 1   | 37.602mb +0.06% | 241.932ms +3.34%   | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_keyset       | 1    | 1   | 37.603mb -0.01% | 422.461ms +2.57%   | ±0.00% -100.00% |
| PostgreSqlExtractorBench | bench_extract_10k_limit_offset | 1    | 1   | 37.608mb -0.02% | 398.084ms +6.11%   | ±0.00% -100.00% |
| TextExtractorBench       | bench_extract_10k              | 1    | 1   | 5.798mb -0.02%  | 54.702ms -0.26%    | ±0.00% -100.00% |
| XmlExtractorBench        | bench_extract_10k              | 1    | 1   | 5.818mb -0.02%  | 672.369ms +1.49%   | ±0.00% -100.00% |
+--------------------------+--------------------------------+------+-----+-----------------+--------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode               | rstdev          |
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 1   | 124.670mb -0.00% | 159.625ms +121.87% | ±0.00% -100.00% |
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 1   | 19.864mb -0.01%  | 130.756ms +77.16%  | ±0.00% -100.00% |
+---------------------------------+--------------------------+------+-----+------------------+--------------------+-----------------+
Loaders
+-----------------------+---------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject             | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+---------------------+------+-----+------------------+-------------------+-----------------+
| CSVLoaderBench        | bench_load_10k      | 1    | 1   | 47.953mb -0.00%  | 139.721ms +98.62% | ±0.00% -100.00% |
| DbalLoaderBench       | bench_load_10k      | 1    | 1   | 35.102mb +0.04%  | 2.947s +155.91%   | ±0.00% -100.00% |
| ExcelLoaderBench      | bench_load_10k_ods  | 1    | 1   | 6.729mb -0.02%   | 3.060s +100.79%   | ±0.00% -100.00% |
| ExcelLoaderBench      | bench_load_10k_xlsx | 1    | 1   | 11.397mb -0.01%  | 4.404s +85.09%    | ±0.00% -100.00% |
| JsonLoaderBench       | bench_load_10k      | 1    | 1   | 82.785mb -0.00%  | 182.377ms +66.25% | ±0.00% -100.00% |
| ParquetLoaderBench    | bench_load_10k      | 1    | 1   | 794.693mb +0.01% | 19.052s -27.54%   | ±0.00% -100.00% |
| PostgreSqlLoaderBench | bench_load_10k      | 1    | 1   | 37.589mb -0.00%  | 838.545ms -4.03%  | ±0.00% -100.00% |
| TextLoaderBench       | bench_load_10k      | 1    | 1   | 19.253mb -0.01%  | 35.540ms +0.17%   | ±0.00% -100.00% |
+-----------------------+---------------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode               | rstdev          |
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 107.266mb -0.00% | 1.176s +118.30%    | ±0.00% -100.00% |
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 56.663mb -0.00%  | 613.246ms +126.08% | ±0.00% -100.00% |
| EntryFactoryBench | bench_entry_factory        | 1    | 1   | 16.345mb -0.01%  | 108.911ms +79.27%  | ±0.00% -100.00% |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 1   | 95.165mb -0.00%  | 7.023ms +65.70%    | ±0.00% -100.00% |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 1   | 112.559mb -0.00% | 502.540ms +103.20% | ±0.00% -100.00% |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 1   | 95.279mb -0.00%  | 46.125ms +79.86%   | ±0.00% -100.00% |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 1   | 96.040mb -0.00%  | 2.328ms +30.35%    | ±0.00% -100.00% |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 1   | 96.040mb -0.00%  | 2.367ms +30.23%    | ±0.00% -100.00% |
| RowsBench         | bench_entries_on_10k       | 2    | 1   | 94.201mb -0.00%  | 4.673ms +20.78%    | ±0.00% -100.00% |
| RowsBench         | bench_filter_on_10k        | 2    | 1   | 94.730mb -0.00%  | 30.285ms +81.63%   | ±0.00% -100.00% |
| RowsBench         | bench_find_on_10k          | 2    | 1   | 94.730mb -0.00%  | 35.273ms +112.71%  | ±0.00% -100.00% |
| RowsBench         | bench_find_one_on_10k      | 10   | 1   | 93.418mb -0.00%  | 2.700μs +35.41%    | ±0.00% -100.00% |
| RowsBench         | bench_first_on_10k         | 10   | 1   | 93.418mb -0.00%  | 0.400μs 0.00%      | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 1   | 102.479mb -0.00% | 32.928ms +100.36%  | ±0.00% -100.00% |
| RowsBench         | bench_map_on_10k           | 2    | 1   | 131.906mb -0.00% | 135.239ms +82.13%  | ±0.00% -100.00% |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 1   | 95.249mb -0.00%  | 2.584ms +56.18%    | ±0.00% -100.00% |
| RowsBench         | bench_partition_by_on_10k  | 2    | 1   | 98.641mb -0.00%  | 124.602ms +96.92%  | ±0.00% -100.00% |
| RowsBench         | bench_remove_on_10k        | 2    | 1   | 96.302mb -0.00%  | 7.444ms +96.73%    | ±0.00% -100.00% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 1   | 93.803mb -0.00%  | 82.755ms +96.58%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_by_on_1k        | 2    | 1   | 93.803mb -0.00%  | 82.582ms +98.08%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 1   | 93.803mb -0.00%  | 82.194ms +95.28%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 1   | 95.861mb -0.00%  | 16.583ms +91.30%   | ±0.00% -100.00% |
| RowsBench         | bench_sort_on_1k           | 2    | 1   | 93.611mb -0.00%  | 64.922ms +100.64%  | ±0.00% -100.00% |
| RowsBench         | bench_take_1k_on_10k       | 10   | 1   | 93.418mb -0.00%  | 26.200μs +92.82%   | ±0.00% -100.00% |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 1   | 93.418mb -0.00%  | 31.300μs +94.36%   | ±0.00% -100.00% |
| RowsBench         | bench_unique_on_1k         | 2    | 1   | 112.560mb -0.00% | 464.034ms +88.90%  | ±0.00% -100.00% |
| TypeDetectorBench | bench_type_detector        | 1    | 1   | 43.526mb -0.00%  | 678.085ms +102.94% | ±0.00% -100.00% |
| TypeDetectorBench | bench_type_detector        | 1    | 1   | 12.584mb -0.01%  | 140.560ms +106.73% | ±0.00% -100.00% |
+-------------------+----------------------------+------+-----+------------------+--------------------+-----------------+
Parquet Library
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+
| benchmark          | subject                         | revs | its | mem_peak         | mode               | rstdev          |
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+
| ParquetWriterBench | bench_write_batch               | 1    | 1   | 12.696mb -12.72% | 389.287ms +71.18%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_gzip                | 1    | 1   | 11.356mb +0.01%  | 396.893ms +79.23%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_row_by_row          | 1    | 1   | 12.696mb -12.72% | 347.287ms +52.76%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_snappy              | 1    | 1   | 12.696mb -12.72% | 360.684ms +58.78%  | ±0.00% -100.00% |
| ParquetWriterBench | bench_write_uncompressed        | 1    | 1   | 11.080mb +0.01%  | 411.736ms +112.77% | ±0.00% -100.00% |
| ParquetReaderBench | bench_page_headers              | 1    | 1   | 7.823mb -0.01%   | 4.219s +122.70%    | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_metadata             | 1    | 1   | 6.518mb -0.02%   | 14.715ms +74.86%   | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_schema               | 1    | 1   | 6.518mb -0.02%   | 13.365ms +58.60%   | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_all_columns   | 1    | 1   | 10.094mb -0.20%  | 10.083s +28.35%    | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_single_column | 1    | 1   | 7.391mb -0.27%   | 398.448ms -11.18%  | ±0.00% -100.00% |
| ParquetReaderBench | bench_read_values_with_limit    | 1    | 1   | 7.919mb -0.41%   | 33.205ms +37.07%   | ±0.00% -100.00% |
+--------------------+---------------------------------+------+-----+------------------+--------------------+-----------------+

@norberttech norberttech merged commit 6691db8 into 1.x Dec 29, 2025
21 checks passed
@norberttech norberttech deleted the bug/openspout-dependency branch December 29, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants