Remove dead code and passthrough properties from data model

[FBumann]

Summary

• Remove unused categorization properties from StatusData
• Remove 9 passthrough properties from StoragesModel that just delegated to self.data.X
• Remove 1 passthrough property from FlowsModel
• Replace all internal call sites with direct self.data.X access

Changes

Dead code removed (batched.py)

• StatusData.with_effects_per_active_hour and StatusData.with_effects_per_startup — categorization lists that were never accessed. The actual effect values (effects_per_active_hour, effects_per_startup) are applied correctly via a different code path in FlowsModel and ComponentsModel.

Passthrough properties removed (components.py — StoragesModel)

9 properties eliminated, replaced with direct self.data.X at all call sites:

• with_investment, with_optional_investment, with_mandatory_investment
• storages_with_investment, storages_with_optional_investment
• optional_investment_ids, mandatory_investment_ids
• invest_params, _investment_data

Kept investment_ids — it has 4 external callers in optimization.py.

Passthrough property removed (elements.py — FlowsModel)

• _previous_status → replaced 3 call sites with self.data.previous_states

Test plan

• All 402 math tests pass (pytest tests/test_math/)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/element-data-classes+simplifications

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}