Merged
Conversation
fjosw
approved these changes
Nov 25, 2025
Owner
fjosw
left a comment
fjosw
left a comment
There was a problem hiding this comment.
Do you plan to use and extend the sfcf input functionality longterm? If so, it might be worth refactoring the module as a lot of special cases and custom logic has accumlated over time which feels prone to non-trivial bugs.
Collaborator
Author
|
Yes, I agree. At the moment, I am not planning to extend its functionality, but I can start to refactor it again when I have time (maybe also after we merged the typehints). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is the second part to #275. With this PR, I'm introducing more sophisticated checking of the structure of append-mode files. In particular, the length of the header for each config can have a different length. This is particularly useful when the first config (that this not written with append mode) has slightly different output.
Now the user gets a warning about this and only the "data part" of each chunk is checked to be of equal length.
Also in #275, there was a small bug that I corrected while reimplementing the check for the file structure.