Add a Focus Self transform #5774
Conversation
mstange
force-pushed
the
focus-self-transform
branch
from
d18cff3 to
62f75cd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5774 +/- ##
==========================================
- Coverage 85.71% 85.68% -0.03%
==========================================
Files 317 317
Lines 31216 31264 +48
Branches 8499 8602 +103
==========================================
+ Hits 26756 26790 +34
- Misses 4030 4044 +14
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
focus-self-transform
branch
2 times, most recently
from
fec7650 to
c470427
Compare
locales/en-US/app.ftl
Outdated
| .title = { CallNodeContextMenu--transform-focus-function-title } | ||
| CallNodeContextMenu--transform-focus-function-inverted = Focus on function (inverted) | ||
| .title = { CallNodeContextMenu--transform-focus-function-title } | ||
| CallNodeContextMenu--transform-focus-self-title = |
There was a problem hiding this comment.
Do we expect self to be translated?
There was a problem hiding this comment.
Depends on how the call tree's "Self" column is translated. I've added the following note, does that work?
# The translation for "self" in this string should match the translation used
# in CallTree--samples-self and CallTree--bytes-self. Alternatively it can be
# translated as "self values" or "self time" (though "self time" is less desirable
# because this menu item is also shown in "bytes" mode).
There was a problem hiding this comment.
The note works, but we should add it also for the previous string. You can use a group-level comment (2 hashes), and reset it after this string.
There was a problem hiding this comment.
er wait, I did it wrong
There was a problem hiding this comment.
sorry about that, should be good now
This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions; with this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function.
mstange
force-pushed
the
focus-self-transform
branch
from
4eb37eb to
5450567
Compare
| # $item (String) - Name of the function that transform applied to. | ||
| TransformNavigator--focus-function = Focus: { $item } | ||
| # "Focus self" transform. |
There was a problem hiding this comment.
Same here, worth adding a short note on "self" (no need for it to be as long as the other).
There was a problem hiding this comment.
Fixed, how does this look?
mstange
force-pushed
the
focus-self-transform
branch
from
5450567 to
5d63c03
Compare
mstange
force-pushed
the
focus-self-transform
branch
from
5d63c03 to
7299b85
Compare
2 participants
Deploy preview
This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions. With this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function.
For example, in this profile, you can "focus self" on
HTMLElement.click, and then change the implementation filter to "All Frames". This will show you the overhead on the way to calling the click handler, minus the time spent in the called JS code (profile). If you had just done "focus function" onHTMLElement.click, you would have seen all the time spent in callees too (profile), and you would have needed to drop each JS callee manually.