Simplify and optimize the computation of per-call-node line and address timings #5770
+370
−778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use the total hits anyway, to compute which line to scroll to.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5770 +/- ##
==========================================
- Coverage 85.71% 85.65% -0.06%
==========================================
Files 317 317
Lines 31216 31164 -52
Branches 8595 8584 -11
==========================================
- Hits 26756 26695 -61
- Misses 4030 4039 +9
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
better-call-node-line-and-address-timings
branch
from
b753a70 to
6a0b464
Compare
I didn't add any tests for the new function; I think it is sufficiently covered by the existing tests for getNativeSymbolsForCallNode. And the next commit will make the address / line timings code use it, which will contribute some more test coverage.
mstange
force-pushed
the
better-call-node-line-and-address-timings
branch
from
6a0b464 to
5eaa05f
Compare
…timings / address timings with the help of getCallNodeFramePerStack.
mstange
force-pushed
the
better-call-node-line-and-address-timings
branch
from
5eaa05f to
6ba8c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we don't allocate lots of one-element sets just to compute which line number to scroll to, when a call node is double-clicked.