Skip to content

Fix drag-and-drop overlay triggering during internal drags #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Weberpcc wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

Fix drag-and-drop overlay triggering during internal drags #5750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fa73b
Fix drag-and-drop overlay triggering during internal drags
Weberpcc Jan 11, 2026
d4fe1e2
Merge branch 'main' into fix-dnd-overlay-edge-case
Weberpcc Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/selectors/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,20 +223,29 @@ export const getTimelineHeight: Selector<null | CssPixels> = createSelector(
* Used by the drag and drop component in order to determine if it can
* load a dropped profile file.
*/
export const getIsNewProfileLoadAllowed: Selector<boolean> = createSelector(
export const getIsNewProfileLoadAllowed = createSelector(
getView,
getDataSource,
getZipFileState,
(view, dataSource, zipFileState) => {
getIsDragAndDropDragging,
getDragSource, // ← this is the missing piece
(view, dataSource, zipFileState, isDragging, dragSource) => {
const appPhase = view.phase;
const zipPhase = zipFileState.phase;

const isLoading =
(appPhase === 'INITIALIZING' && dataSource !== 'none') ||
zipPhase === 'PROCESS_PROFILE_FROM_ZIP_FILE';
return !isLoading;

return (
!isLoading &&
isDragging &&
dragSource === 'EXTERNAL_FILE'
);
}
);


/**
* Returns the indexes of categories that are opened in the sidebar,
* for every category
Expand Down