Conversation
bshaffer
force-pushed
the
remove-resource-support
branch
from
346044e to
f26448b
Compare
bshaffer
changed the title
| if (str_starts_with($alg, 'RS')) { | ||
| self::validateRsaKeyLength($key); | ||
| } | ||
| if (!$key = openssl_pkey_get_private($key)) { |
Collaborator
There was a problem hiding this comment.
This is nit and something that I don't think it needs to be changed, but I find this logic a bit convoluted.
It might be good to separate these cases into their own methods like :
private function handleOpenSsl()
private function handleSodyumCrypto()
But this was already this way. Just think it would be a good cleanup for later.
Hectorhammett
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssl in PHP 8.1 no longer uses type
resource. AFAIK, no validresourcecan be supplied to these functions, so they can be removed.NOTE: This commit message merged incorrectly as
add key size validationwhen it should have been what the PR title here is (fix: remove resource support)