RFC[dev-ui]: support for agents in the dev-ui #4240
Conversation
Summary of ChangesHello @xavidop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request proposes an RFC to integrate agent primitives and their sessions into the Genkit Reflection API. The primary objective is to provide robust tooling support for agent development, allowing developers to seamlessly inspect, manage, and debug agents and their conversational flows directly within the Developer UI. This enhancement aims to bridge the current gap where the Reflection API supports actions and flows but lacks awareness of the Agent abstraction layer. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive RFC for extending the Genkit Reflection API to support agents and sessions. The document outlines new API endpoints for listing agents, retrieving agent details, managing sessions, and executing agent conversations. The proposed API surface is well-structured and addresses key development and debugging needs for agent-based applications. The RFC also touches upon important implementation considerations such as agent registry and store abstraction. Overall, this is a valuable addition that will significantly enhance the developer experience for Genkit agents.
| "name": "persistentAgent", | ||
| "description": "An agent with server-side state", | ||
| "hasStore": true, | ||
| "storeType": "postgres", |
There was a problem hiding this comment.
The storeType field currently shows a specific example value "postgres". To make the RFC more generic and descriptive, consider clarifying that this field represents the type of the session store and providing a more abstract description or a note that it's an example.
| "initSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sessionId": {"type": "string"}, | ||
| "messages": {"type": "array"}, | ||
| "state": {}, | ||
| "artifacts": {"type": "array"} | ||
| } | ||
| }, | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "content": {"type": "string"} | ||
| } | ||
| }, | ||
| "outputSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sessionId": {"type": "string"}, | ||
| "messages": {"type": "array"}, | ||
| "state": {}, | ||
| "artifacts": {"type": "array"} | ||
| } | ||
| }, | ||
| "streamSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sessionId": {"type": "string"}, | ||
| "chunk": {}, | ||
| "stateUpdate": {}, | ||
| "artifact": {} | ||
| } |
There was a problem hiding this comment.
The schema definitions (initSchema, inputSchema, outputSchema, streamSchema) currently show empty objects {} for their properties. While this indicates they are objects, it doesn't provide much insight into their expected structure. Consider adding example properties or a more descriptive placeholder to illustrate the typical content of these schemas.
| "createdAt": 1705968000000, | ||
| "updatedAt": 1705968300000, |
There was a problem hiding this comment.
The createdAt and updatedAt fields are shown as numeric timestamps. It would be beneficial to specify the unit of these timestamps (e.g., milliseconds since epoch, Unix timestamp) for clarity and consistency.
| }, | ||
| "init": { | ||
| "sessionId": "sess_abc123", | ||
| "messages": [...], |
There was a problem hiding this comment.
The messages field in the init object is represented as [...]. This is not a valid JSON syntax. Please update it to either an empty array [] or a valid example array of messages.
| "messages": [...], | |
| "messages": [] |
| data: {"sessionId": "sess_abc123", "chunk": {"content": [{"text": "The"}]}} | ||
|
|
||
| event: chunk | ||
| data: {"sessionId": "sess_abc123", "chunk": {"content": [{"text": " weather"}]}} | ||
|
|
||
| event: stateUpdate | ||
| data: {"sessionId": "sess_abc123", "stateUpdate": {"status": "fetching_weather"}} | ||
|
|
||
| event: artifact | ||
| data: {"sessionId": "sess_abc123", "artifact": {"name": "map", "parts": [...]}} | ||
|
|
||
| event: done | ||
| data: {"sessionId": "sess_abc123", "messages": [...], "state": {...}} | ||
|
|
||
| event: telemetry | ||
| data: {"traceId": "trace_xyz"} |
There was a problem hiding this comment.
The data fields for the streaming event types (chunk, stateUpdate, artifact, done, telemetry) are shown as generic JSON objects. While the event types are clear, providing a more explicit structure or referencing a schema for the data content would enhance the clarity of the streaming response format.
xavidop
changed the title
xavidop
changed the title
1 participant
Add support for agents in the UI
Checklist (if applicable):