-
Notifications
You must be signed in to change notification settings - Fork 645
feat(cli): add streaming and reasoning to dev:test-model cmd #4235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hugoaguirre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --stream option to the dev:test-model command, enabling tests to be run against a model's streaming API. The implementation correctly adds the necessary CLI option, passes the flag through to the test execution logic, and handles the aggregation of streamed text chunks. My review focuses on ensuring the aggregated text is correctly applied to the response object for validation. I've identified a high-severity issue where the code makes an unsafe assumption about the structure of the model's response, which could lead to data corruption. A code suggestion is provided to fix this.
| const isMediaOutput = testCase.validators.some((v) => | ||
| v.startsWith('valid-media') | ||
| ); | ||
| const shouldStream = stream && !isMediaOutput; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be an explicit flag on the test...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially opted for the global --stream flag as a way to quickly verify across all the existing core test cases without having to duplicate each one of them. I was thinking stream mode more like a toggle to the existing tests.
I see your point about explicit control. I'm okay to rework this with your suggestion.
If we are keeping the per-test flag, should I go and duplicate the core test cases for this?
Added
--streamflag todev:test-modelcommandcd go genkit dev:test-model googleai/gemini-3-flash-preview --stream -- go run samples/basic/main.goAdded
reasoningvalidator:cd js/testapps/basic-gemini genkit dev:test-model --from-file=../../plugins/google-genai/tests/model-tests-tts.yaml -- tsx src/index.tsIn
model-tests-tts.yamlyou can specify how to enablereasoningfor your model.For Gemini models: