Skip to content

Conversation

@apascal07
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 22, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request proposes a detailed design for implementing session snapshots within the Genkit Go framework. The primary goal is to provide robust mechanisms for capturing, storing, and restoring the state of conversational agents, which will significantly improve debugging capabilities, allow users to resume conversations from any point, and enhance the observability of agent interactions through the developer UI. The design covers API definitions, behavioral specifications, usage examples, and implementation considerations, ensuring a flexible and extensible system for managing agent state history.

Highlights

  • Introduction of Session Snapshots: This PR introduces a comprehensive design for session snapshots in Genkit Go, enabling point-in-time state capture and restoration for debugging, conversation resumption, and enhanced Dev UI observability.
  • Core API Definitions: New core types like Snapshot, SnapshotEvent, SnapshotContext, and SnapshotCallback are defined to manage and interact with session states. The Snapshot struct includes fields for content-addressed ID, parent ID, session ID, creation time, state, and indices.
  • Extended Store Interface: The existing Store[S] interface is extended with new methods (GetSnapshot, SaveSnapshot, ListSnapshots, InvalidateSnapshotsAfter) to support the persistence and retrieval of session snapshots.
  • Flexible Snapshot Configuration: New agent options, including WithSnapshotCallback, allow users to define custom logic for when snapshots are created. Convenience callbacks like SnapshotAlways, SnapshotNever, SnapshotOn, and SnapshotOnChange are also provided.
  • Snapshot Restoration and Tracing Integration: The WithSnapshotID invocation option enables restoring a session from a specific snapshot, marking subsequent snapshots as 'orphaned'. Snapshots are integrated with tracing by recording IDs in span metadata for Dev UI access.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This design document provides a comprehensive and well-structured overview of the session snapshots feature in Genkit Go. The API definitions, behavioral descriptions, and usage examples are clear and helpful. The rationale section effectively explains the design decisions. I have a few minor suggestions for clarification regarding the TurnIndex definition and the computeStateHash function, which are detailed in the specific review comments.

Index int `json:"index"`

// TurnIndex is the turn number when this snapshot was created (0-indexed).
// Turn 0 is after the first user input and agent response.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The definition of TurnIndex as "Turn 0 is after the first user input and agent response" might be slightly ambiguous. If Turn 0 is after the first full turn, it implies the initial state before any interaction would not have a TurnIndex of 0. Consider clarifying if TurnIndex is 0-indexed for the state before any user input, or if it represents the number of completed turns. For example, if TurnIndex is 0 for the initial state, then after the first user input and agent response, it would become 1.

return true
}
// Compare by computing content-addressed IDs
return computeStateHash(snap.State) != computeStateHash(*snap.PrevState)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The computeStateHash function is used here to compare states but is not defined or explained anywhere in the document. Please add a brief explanation of what this function does (e.g., "a helper function that computes a SHA256 hash of the JSON-serialized state") or provide a reference to its definition if it exists elsewhere.

| `SnapshotEventInvocationEnd` | When the agent function returns |

At each point, the snapshot callback is invoked. If it returns true:
1. Compute the snapshot ID by hashing the state (SHA256)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the previous comment, computeStateHash is mentioned here without a definition. It would be beneficial to define this function or refer to its definition to ensure clarity on how snapshot IDs are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant