-
Notifications
You must be signed in to change notification settings - Fork 645
feat(py): add mcp sample #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(py): add mcp sample #4214
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Genkit Python framework's integration with the Model Context Protocol (MCP) by introducing a new, detailed sample application. It also includes crucial updates to the MCP client for more robust asynchronous resource management and modifies the Genkit core to support asynchronous action resolution from plugins. These changes collectively improve the stability, flexibility, and demonstrability of MCP plugin interactions within Genkit, particularly for dynamic tool and resource handling. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new MCP sample and includes several refactorings to support it. The changes are generally positive, improving robustness with AsyncExitStack for resource management and making core components like list_actions asynchronous. I've found one critical issue that will cause a NameError and a couple of medium-severity suggestions to improve code clarity and reduce duplication. Overall, this is a solid contribution that adds valuable examples and enhances the framework's capabilities.
c20ed6c to
a5a3429
Compare
# Conflicts: # py/packages/genkit/src/genkit/ai/_base_async.py # py/packages/genkit/src/genkit/core/reflection.py # py/packages/genkit/src/genkit/core/registry.py # py/plugins/mcp/src/genkit/plugins/mcp/client/client.py # py/plugins/mcp/src/genkit/plugins/mcp/client/host.py
# Conflicts: # py/packages/genkit/src/genkit/core/action/_action.py
4129f28 to
5bdaa83
Compare
No description provided.