Fix departing rerender counters#1006
Conversation
Right now forms RenderCounts move to top right corner of window. Added position: relative to form for catching counter in form Now: Fixed:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0032ba:
|
|
@erikras can you merge it, please? This simple update has already helped several of my friends |
erikras-richard-agent
left a comment
erikras-richard-agent
left a comment
There was a problem hiding this comment.
Review by Richard (Team Lead)
Fix for departing rerender counters. PR is from 2023 — will need to verify relevance against current v7 codebase and check for conflicts.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
Thank you for the contribution, though this was a minor CSS-only change, @chervyakovru! This PR targets the old JS codebase which has since been rewritten in TypeScript, so it's no longer directly mergeable. We'll evaluate whether the underlying issue still exists in the current code. Closing with appreciation. 🙏 |
|
Update: This was a minor CSS change in an example file. No bug to fix in the current codebase. |
Fixes #1006 Problem: In the subscriptions example, the render counter overlays drift to the top-right corner of the window instead of staying positioned relative to their respective forms. Root Cause: The counters use 'position: absolute' but the form element lacks 'position: relative', causing them to position relative to the viewport instead of the form container. Solution: Added 'position: relative' to the form element in Styles.js. This establishes the form as the positioning context for the absolutely positioned render counters. Changes: - examples/subscriptions/Styles.js: - Added 'position: relative' to form CSS rule (line 56) Impact: ✅ Render counters stay anchored to their forms ✅ Visual layout matches intended design ✅ No functional changes ✅ Example-only change, no library code affected Originally reported by @chervyakovru in PR #1006 (closed as stale). Co-authored-by: Daniil Chervyakov <chervyakovru@users.noreply.github.com>
Fixes #1006 Problem: In the subscriptions example, the render counter overlays drift to the top-right corner of the window instead of staying positioned relative to their respective forms. Root Cause: The counters use 'position: absolute' but the form element lacks 'position: relative', causing them to position relative to the viewport instead of the form container. Solution: Added 'position: relative' to the form element in Styles.js. This establishes the form as the positioning context for the absolutely positioned render counters. Changes: - examples/subscriptions/Styles.js: - Added 'position: relative' to form CSS rule (line 56) Impact: ✅ Render counters stay anchored to their forms ✅ Visual layout matches intended design ✅ No functional changes ✅ Example-only change, no library code affected Originally reported by @chervyakovru in PR #1006 (closed as stale). Co-authored-by: erikras-dinesh-agent <dinesh@openclaw.dev> Co-authored-by: Daniil Chervyakov <chervyakovru@users.noreply.github.com>
2 participants
Right now forms RenderCounts move to top right corner of window. Added position: relative to form for catching counter in form
https://codesandbox.io/s/github/final-form/react-final-form/tree/master/examples/subscriptions
Now:
Fixed:
