Closed
Conversation
Author
|
This change should also make it very easy to add support for |
dcousens
reviewed
Dec 11, 2024
| 'use strict' | ||
|
|
||
| const base64 = require('base64-js') | ||
| const hextreme = require('hextreme') |
Collaborator
There was a problem hiding this comment.
A new dependency as non-battle-tested as a newly published package - unfortunately - isn't tenable for Buffer.
The TextDecoder option presented previously was an easy option as the complexity of review remained in band.
Author
|
OK. Kind of disappointing, but I guess I see where you're coming from. I'll start again and probably just do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #364, I created a new package — hextreme — for fast hex and base64 encoding and decoding, and I've updated this library to use it.
The tests are passing, and I've added benchmarks that show performance gains (in Node) of 3 – 13x:
Before:
After:
Please let me know if you need anything else in order to be able to merge this.