Support inherited static functions#679
Support inherited static functions#679letynsoft wants to merge 11 commits intofelixfbecker:masterfrom
Conversation
|
Hmm, from the tests it really doesn't like that, but from the functionality it works nice :-( |
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
===========================================
+ Coverage 82.17% 82.27% +0.1%
- Complexity 935 940 +5
===========================================
Files 44 44
Lines 2154 2167 +13
===========================================
+ Hits 1770 1783 +13
Misses 384 384
|
|
Could you explain what this PR fixes? What do you mean with parent contexts? |
|
eg. and then when you call |
src/DefinitionResolver.php
Outdated
| $name = (string)$className . '::$' . $memberName; | ||
| } else { | ||
| $name = (string)$className . '::' . $scoped->memberName->getText($scoped->getFileContents()); | ||
| } |
There was a problem hiding this comment.
There is a lot of logic here that does not change on each loop iteration, such as the instanceof checks above and the member name. Could you save this in variables and move it out of the loop?
|
Also, could you add a test? |
They are tested as references to the TestClass
|
Hi, |
When the resolveScopedPropertyAccessExpressionNodeToFqn cannot find the definition, try it the extended class