Skip to content

Update tortoise-orm requirement from <0.19.0,>=0.17.6 to >=0.17.6,<0.20.0#3

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/tortoise-orm-gte-0.17.6-and-lt-0.20.0
Closed

Update tortoise-orm requirement from <0.19.0,>=0.17.6 to >=0.17.6,<0.20.0#3
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/pip/tortoise-orm-gte-0.17.6-and-lt-0.20.0

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Mar 28, 2022

Updates the requirements on tortoise-orm to permit the latest version.

Release notes

Sourced from tortoise-orm's releases.

0.19.0

Added

  • Added psycopg backend support.
  • Added a new unified and robust connection management interface to access DB connections which includes support for lazy connection creation and much more. For more details, check out this PR.
  • Added TimeField. (#1054).
  • Added ArrayField for postgres.

Fixed

  • Fix bulk_create doesn't work correctly with more than 1 update_fields. (#1046)
  • Fix bulk_update errors when setting null for a smallint column on postgres. (#1086)

Deprecated

  • Existing connection management interface and related public APIs which are deprecated:
  • Tortoise.get_connection
  • Tortoise.close_connections

Changed

  • Refactored tortoise.transactions.get_connection method to tortoise.transactions._get_connection. Note that this method has now been marked private to this module and is not part of the public API
Changelog

Sourced from tortoise-orm's changelog.

0.19.0

Added ^^^^^

  • Added psycopg backend support.
  • Added a new unified and robust connection management interface to access DB connections which includes support for lazy connection creation and much more. For more details, check out this PR <https://github.com/tortoise/tortoise-orm/pull/1001>_
  • Added TimeField. (#1054)
  • Added ArrayField. Fixed ^^^^^
  • Fix bulk_create doesn't work correctly with more than 1 update_fields. (#1046)
  • Fix bulk_update errors when setting null for a smallint column on postgres. (#1086) Deprecated ^^^^^^^^^^
  • Existing connection management interface and related public APIs which are deprecated:
  • Tortoise.get_connection
  • Tortoise.close_connections Changed ^^^^^^^
  • Refactored tortoise.transactions.get_connection method to tortoise.transactions._get_connection. Note that this method has now been marked private to this module and is not part of the public API

0.18.1

Added ^^^^^

  • Add on conflict do update for bulk_create. (#1024) Fixed ^^^^^
  • Fix bulk_create error. (#1012)
  • Fix unittest invalid.
  • Fix bulk_update in postgres with some type. (#968) (#1022)

0.18.0

Added ^^^^^

  • Add Case-When support. (#943)
  • Add Rand/Random function in contrib. (#944)
  • Add ON CONFLICT support in INSERT statements. (#428) Fixed ^^^^^
  • Fix bulk_update error when pk is uuid. (#986)
  • Fix mutable default value. (#969) Changed ^^^^^^^
  • Move Function, Aggregate from functions.py to expressions.py. (#943)
  • Move Q from query_utils.py to expressions.py.
  • Replace python-rapidjson to orjson.

... (truncated)

Commits
  • 13c82f8 docs: update changelog
  • 86acdfe chore: upgrade version 0.19.0
  • 26a8bc3 chore: upgrade pypika-tortoise
  • e635520 feat: change update and fix test
  • 5d82d51 feat: add ArrayField
  • f0b3504 test: fix test_bulk_create_mix_specified
  • 834081c test: fix test_bulk_create_mix_specified
  • a987d70 Added TimeField (#1090)
  • 9709355 A unified, robust and bug-free connection management interface for the ORM (#...
  • 811bbcb style: fix mypy
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update tortoise-orm requirement
6392e32 
Updates the requirements on [tortoise-orm](https://github.com/tortoise/tortoise-orm) to permit the latest version.
- [Release notes](https://github.com/tortoise/tortoise-orm/releases)
- [Changelog](https://github.com/tortoise/tortoise-orm/blob/develop/CHANGELOG.rst)
- [Commits](tortoise/tortoise-orm@0.17.6...0.19.0)

---
updated-dependencies:
- dependency-name: tortoise-orm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 28, 2022
@dependabot dependabot bot requested a review from frankie567 March 28, 2022 04:24
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #3 (6392e32) into main (68d250c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          126       126           
=========================================
  Hits           126       126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d250c...6392e32. Read the comment docs.

@Tobi-De
Copy link

Tobi-De commented Apr 7, 2022 •
edited
Loading

Hi @frankie567, hope you are well, Is anything required to get this approved?

@ShipraShalini
Copy link

ShipraShalini commented Oct 12, 2022

Hi @frankie567, It would be really helpful if this could get merged. We can't update tortoise-orm to v19 as this PR is blocking it.
Thanks in advance.

@Tobi-De
Copy link

Tobi-De commented Oct 12, 2022 •
edited
Loading

Hi @frankie567, It would be really helpful if this could get merged. We can't update tortoise-orm to v19 as this PR is blocking it. Thanks in advance.

@ShipraShalini If you need a database adapter for tortoise-orm for fastapi-users v10 try this. This official adapter is no longer maintained.

@frankie567
Copy link
Member

frankie567 commented Oct 12, 2022

Thank you @Tobi-De 🙏

Would you be okay if I link to your implementation in the README so people know they have to switch over?

@Tobi-De
Copy link

Tobi-De commented Oct 12, 2022

Thank you @Tobi-De 🙏

Would you be okay if I link to your implementation in the README so people know they have to switch over?

No problem

@ShipraShalini
Copy link

ShipraShalini commented Oct 12, 2022

@Tobi-De fastapi-users-tortoise doesn't seem like a drop-in replacement.

from fastapi_users.db import TortoiseUserDatabase
ImportError: cannot import name 'TortoiseUserDatabase' from 'fastapi_users.db' (/usr/local/lib/python3.10/site-packages/fastapi_users/db/init.py)

Can you please add a migration documentation?

@Tobi-De
Copy link

Tobi-De commented Oct 12, 2022 •
edited
Loading

@Tobi-De fastapi-users-tortoise doesn't seem like a drop-in replacement.

from fastapi_users.db import TortoiseUserDatabase
ImportError: cannot import name 'TortoiseUserDatabase' from 'fastapi_users.db' (/usr/local/lib/python3.10/site-packages/fastapi_users/db/init.py)

Can you please add a migration documentation?

@ShipraShalini
Oh, you're right, I forgot that, but the only thing you need to do is update your import statements.
ex:

# replace this
from fastapi_users.db import TortoiseUserDatabase
# with 
from fastapi_users_tortoise import TortoiseUserDatabase

@Tobi-De Tobi-De mentioned this pull request Oct 12, 2022
Open
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Aug 11, 2023

Superseded by #4.

@dependabot dependabot bot closed this Aug 11, 2023
@dependabot dependabot bot deleted the dependabot/pip/tortoise-orm-gte-0.17.6-and-lt-0.20.0 branch August 11, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankie567 frankie567 Awaiting requested review from frankie567

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tobi-De @ShipraShalini @frankie567

Comments