Adding type class for operator map for type configurable parser#6
Open
fshao816 wants to merge 1 commit intofacaiy:masterfrom
Open
Adding type class for operator map for type configurable parser#6fshao816 wants to merge 1 commit intofacaiy:masterfrom
fshao816 wants to merge 1 commit intofacaiy:masterfrom
Conversation
Owner
|
Cool, @fshao816 ! The PR help to handle both I'm glad to take a review, however, CI run failed. Please check the Moreover, we'll be more confident after those points below are checked:
Be free to ping me if you need more help. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a PR for your consideration; basically made the operators map an implicit. Note that this does change the way you call
MathExp.parsehowever:You'll have to explicitly supply the type since there's no way to infer it.
The way we are using it with saddle looks something like this:
We'll be building out unaryOps (for saddle Vecs) in the future.
Nice work on the library!