- a little hack to enable custom request decryption#86
Open
vietanh85 wants to merge 6 commits intoexpressjs:masterfrom
Open
- a little hack to enable custom request decryption#86vietanh85 wants to merge 6 commits intoexpressjs:masterfrom
vietanh85 wants to merge 6 commits intoexpressjs:masterfrom
Conversation
vietanh85
commented
Mar 25, 2015
vietanh85
commented
- Sometime we need to encrypt response and request from client to server to ensure security
vietanh85
changed the title
Contributor
|
Makes sense. Can the decryption be done as a stream instead of a sync decryption? |
Author
|
Since, we are using raw-body to convert request stream to a buffer. In addition, I've learned that, there is no way to modify a readable stream in nodejs. So I think we cannot decrypt a stream. |
Contributor
|
I'm talking about changing the interface here to take a TransformStream, rather than do it prior to calling this module. |
Contributor
|
Ok, sorry we misunderstood. The user needs to pass in a TransformStream as the decrypt argument. What we have here is still the same DoS vector. |
Contributor
|
And if possible, please add tests and make sure decryption occurs after inflation. |
Fatih86
approved these changes
May 31, 2021
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
0ad1d88 to
2a2f471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.