-
Notifications
You must be signed in to change notification settings - Fork 18
Long integers and strings #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pheest
wants to merge
63
commits into
epics-modules:master
Choose a base branch
from
pheest:long-integers-and-strings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, resulting in build errors Replaced with use of xcopy for windows - a better approach could be found, I think. A DLL imported as a Python module needs to have the extension .pyd - overrode SHRLIB_SUFFIX_BASE to create _dbapi.pyd. Also added Windows library dependencies.
… make them conditional on epics version number.
…nt to keep in main branch.
…CONFIG_BASE for the definition of the INSTALL macro. epicsThreadExitMain is deprecated by recent EPICS base versions (and resolves to cantProceed). Being unsure as to what best to do about this, I commented it out in devSupMain.cpp. Python 2.7 has been obsoleted and won't install on the runner without taking special measures. Being unsure what to do about this, I have commented out builds that invoke 2.7. Github Windows-latest (i.e. Windows server 2022) is installed with VS2022 (not VS2019). Use of the debug build configuration will seek to link with the Python debug libraries that are not normally installed. I have a solution to this problem but we should debate how to proceed. Github Windows server 2019 is, I think, installed with VS2019, this should build OK with default configuration.
On Windows, the library isn't in a system folder so the fully-qualified path is required.
…to the linker order issue. Commissioned use of nose testing on Windows. This requires: a. (already noted) issue regarding simultaneous temporary file read and write to be addressed in util.py. b. Windows .pyd file does not search PATH for DLLs - instead the EPICS base path has to be explicitly added in __init__.py with os.add_dll_directory. Tested with Python 3.11 on Windows.
…newer versions of numpy.
Excluded int64 and long string for that reason. Base 3.14 doesn't work because RuntimeError: Requires Base >=3.15.
…ing messages. This branch focuses only on long strings and ints.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements long strings and integers.
I reduced it from my existing Windows merge and included only the relevant strings and integers stuff.
This PR works from @andrewstarritt PR #30 and includes tests and some corrections.