Function diff: Implement "Go to line number"

[LagoLunatic]

This adds a text field to the function diff view that lets you type a line number in and be automatically scrolled to the first asm line that corresponds to that line of source code. This can be useful for very large functions so you don't have to manually scroll through thousands of lines of asm to find what you're looking for:

Also added a Ctrl+G shortcut to focus the text field. (You don't need to press the shortcut for the scrolling to start happening, it just takes whatever you typed and starts scrolling to it immediately.)

If line info is disabled of course it doesn't do anything. Also, I didn't implement this for the left side, just the right side (in both joint and split view). Not sure if this would ever be useful for the left side.

[tomsons26]

Not sure on the visual aspect but perhaps goto offset to go along with it?
Maybe on target asm plane?

[LagoLunatic]

What's the specific use case for goto offset? Line numbers you can see in the source file. Where will you see an offset outside of objdiff and want to quickly jump to that offset in the function within objdiff?

[LagoLunatic]

Oh maybe switch statement jump tables? objdiff doesn't really show those very well so every once in a while you have to look at the addends for each case and fix the function cases to match those offsets manually.

Might be worth having but it could look cluttered to have another text field for that. Would it be too confusing if they shared a field and 124 jumped to line 124 but 0x124 jumped to offset 0x124?

[dbalatoni13]

Maybe a "go to virtual address" would be useful sometimes

[LagoLunatic]

Maybe the goto field could distinguish between them like this?

• line:1234
• offset:124/offs:124
• address:80123478/addr:80123478