This repository was archived by the owner on Aug 19, 2025. It is now read-only.
fix wrong type annotation for properties parameter in Object type#129
Open
mahdihaghverdi wants to merge 1 commit intoencode:masterfrom
Open
fix wrong type annotation for properties parameter in Object type#129mahdihaghverdi wants to merge 1 commit intoencode:masterfrom
mahdihaghverdi wants to merge 1 commit intoencode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I found a subtle bug in the
__init__parameters of Object type.Then i shared the bug at the community discussions
and i got the answer to make a pr.
After fixing the bug, I ran pytest through all the tests and they all passed.
Thanks