Skip to content

Simplify isAsyncFunction calculation. NFC #26004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Dec 23, 2025
+5 −11
Merged

Simplify isAsyncFunction calculation. NFC #26004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/jsifier.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,15 +535,9 @@ function(${args}) {
deps.push('setTempRet0');
}

let isAsyncFunction = false;
if (ASYNCIFY) {
const original = LibraryManager.library[symbol];
if (typeof original == 'function') {
isAsyncFunction = LibraryManager.library[symbol + '__async'];
}
if (isAsyncFunction) {
asyncFuncs.push(symbol);
}
const isAsyncFunction = LibraryManager.library[symbol + '__async'];
if (ASYNCIFY && isAsyncFunction) {
asyncFuncs.push(symbol);
}

if (symbolsOnly) {
Expand Down Expand Up @@ -622,9 +616,8 @@ function(${args}) {

const original = LibraryManager.library[symbol];
let snippet = original;

// Check for dependencies on `__internal` symbols from user libraries.
const isUserSymbol = LibraryManager.library[symbol + '__user'];
// Check for dependencies on `__internal` symbols from user libraries.
for (const dep of deps) {
if (isUserSymbol && LibraryManager.library[dep + '__internal']) {
warn(`user library symbol '${symbol}' depends on internal symbol '${dep}'`);
Expand Down Expand Up @@ -773,6 +766,7 @@ function(${args}) {
contentText += `\n${mangled}.sig = '${sig}';`;
}
if (ASYNCIFY && isAsyncFunction) {
assert(isFunction);
contentText += `\n${mangled}.isAsync = true;`;
}
if (isStub) {
Expand Down