MigraDoc support for rendering barcodes and PDFSharp support for Code 128 barcodes#93
Open
danports wants to merge 2 commits intoempira:masterfrom
Open
MigraDoc support for rendering barcodes and PDFSharp support for Code 128 barcodes#93danports wants to merge 2 commits intoempira:masterfrom
danports wants to merge 2 commits intoempira:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a combination of code from two forum posts plus some necessary updates to get the code to compile against the latest version:
It could use some polishing, particularly in the Code 128 implementation, but I just wanted to open this PR before I went any further to see if you guys would be open to these changes - I'm not really sure why this support was never added to MigraDoc/PDFSharp earlier. I have done some testing and it works well for my use case, though I haven't tested all of the options.