Add Hebrew-script RTL run preprocessing and unit tests#322
Open
ronenfe wants to merge 7 commits intoempira:masterfrom
Open
Add Hebrew-script RTL run preprocessing and unit tests#322ronenfe wants to merge 7 commits intoempira:masterfrom
ronenfe wants to merge 7 commits intoempira:masterfrom
Conversation
• Implement simple RTL preprocessor in PdfSharp.Events.RenderEvents that detects Hebrew-script characters (U+0590..U+05FF and U+FB1D..U+FB4F) and reverses RTL runs before PrepareTextEvent handlers are invoked. • Keep heuristic limited to Hebrew-script languages (Hebrew, Yiddish, Judeo‑Ladino) to avoid complex shaping issues. • Add unit tests ReverseRtlTests to verify mixed LTR/RTL run reordering. • Remove broader RTL detection that included shaping‑required scripts. Files changed: • src/foundation/src/PDFsharp/src/PdfSharp/Events/RenderEvents.cs • src/foundation/src/PDFsharp/tests/PdfSharp.Tests/Drawing/text/ReverseRtlTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Implement simple RTL preprocessor in PdfSharp.Events.RenderEvents that detects Hebrew-script characters (U+0590..U+05FF and U+FB1D..U+FB4F) and reverses RTL runs before PrepareTextEvent handlers are invoked. • Keep heuristic limited to Hebrew-script languages (Hebrew, Yiddish, Judeo‑Ladino) to avoid complex shaping issues. • Add unit tests ReverseRtlTests to verify mixed LTR/RTL run reordering. • Remove broader RTL detection that included shaping‑required scripts. Files changed:
• src/foundation/src/PDFsharp/src/PdfSharp/Events/RenderEvents.cs • src/foundation/src/PDFsharp/tests/PdfSharp.Tests/Drawing/text/ReverseRtlTests.cs