Determine Property Types in Native Classes#2279
Open
dill-larson wants to merge 4 commits intoember-cli:masterfrom
Open
Determine Property Types in Native Classes#2279dill-larson wants to merge 4 commits intoember-cli:masterfrom
dill-larson wants to merge 4 commits intoember-cli:masterfrom
Conversation
isCallWithArrowFunctionExpression and isPropAccessor
For ActionMethod and Accessors
Contributor
|
looks like some tests are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Requirement/Problem
Add ability to distinguish property/method types in Native JS classes, for later consumption of
reportUnorderedPropertiesRelates to #417
Solution
'single-line-functions'e.g.
['single-line-function', 'single-line-accessor']e.g.
['actions', 'action']ToDo
reportUnorderedPropertiesand wire-up to order-in-* rules