Fix: preserve user-defined Content-Type in fetch responses #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
approved these changes
Jan 4, 2026
Member
sgammon
left a comment
sgammon
left a comment
There was a problem hiding this comment.
thank you for the fix; please fix formatting and don't forget to rebase, as the null ConsoleIntrinsic bug had a fix merged
Comment on lines
156
to
158
| if (!headers.has("Content-Type")) { | ||
| headers.set("Content-Type", "text/plain") | ||
| } |
Comment on lines
182
to
184
| if (!headers.has("Content-Type")) { | ||
| headers.set("Content-Type", "application/json") | ||
| } |
Comment on lines
197
to
200
| val serializedArgs = when { | ||
| args == null -> listOf("null") | ||
| else -> args.toList().filterNotNull() | ||
| } |
Member
There was a problem hiding this comment.
args == null
and
else ->
should both be indented here
sgammon
requested changes
Jan 4, 2026
Member
sgammon
left a comment
sgammon
left a comment
There was a problem hiding this comment.
oops, once the changes above are posted, I can approve
SriLakshmiPolavarapu
force-pushed
the
fix-content-type-overwrite
branch
from
ffd0b1f to
c77e982
Compare
Author
|
Hi, I’ve fixed the formatting and rebased onto the latest main as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where FetchResponse overwrote user-defined Content-Type headers.
Before, mapResponseBody() always replaced Content-Type based on body type.
After, ensures Content-Type is only set when not already provided.
Fixes #1817