Open
Conversation
The initializing isn't usually necessary, but I sourced
`nodeinspect.vim` when tracking down other issues, which broke the
watches because then `s:session["watches"]` didn't exist any more.
If we already set s:session["watches"] = {} on startup, there's no
reason to not set it in the init that I can see. I left the set in
loadSessionFile() in as well, in case there's some edge case where we
are loading a session file and don't want to merge with some existing
session watches or something.
Also, we were unnecessarily looping through the keys and calling
AddBulk() with the same argument multiple times. It was idempotent so it
was fine, but it's also not useful, and I imagine left over from some
previous restructuring.
There were a bunch of little spaces that crept in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the commit note, this shouldn't usually be a problem, but I reloaded
nodeinspect.vimwhen doing other debugging and started getting an error about the watches key missing. Since we do access it without checking, I figure it might as well just set watches to an empty object from file init.While here I also noticed that there was an unnecessary loop, presumably left over from earlier refactoring, and also some spacing inconsistency, so I fixed up the spacing and added modelines to hopefully keep things more consistent moving forward.